Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): enforce legacy failover when needed #1936

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix(query): enforce legacy failover when needed #1936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion coordinator/src/main/scala/filodb.coordinator/queryplanner/HighAvailabilityPlanner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,12 @@ class HighAvailabilityPlanner(dsRef: DatasetRef,
}
//scalastyle:on method.length

def materializeLegacy(logicalPlan: LogicalPlan, qContext: QueryContext): ExecPlan = {
def materializeLegacy(logicalPlan: LogicalPlan, oqContext: QueryContext): ExecPlan = {
// ensure that we do not use any features of shard level failover
val plannerParams = oqContext.plannerParams.copy(
failoverMode = LegacyFailoverMode
)
val qContext = oqContext.copy(plannerParams = plannerParams)
// lazy because we want to fetch failures only if needed
lazy val offsetMillis = LogicalPlanUtils.getOffsetMillis(logicalPlan)
lazy val periodicSeriesTime = getTimeFromLogicalPlan(logicalPlan)
Expand Down