fix executable path in desktop file #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file shipped upstream tries to execute supersonic-desktop, which we do not have. We also use the --set-icon shortcut to resolve any possible ambiguity with multiple --set-key options. I *think* multiples are allowed, but it seems prettier (and shorter) that way anyway.
|
Started test build 96689 |
anarcat
changed the title
|
Build 96689 failed |
|
wow, @dweymouth it looks like flatpak introduced a new linting error that we just tripped, possibly as a coincidence: https://docs.flathub.org/docs/for-app-authors/linter/#appstream-missing-developer-name amazingly, it's complaining about a deprecated tag too: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer_name amazing. |
builder failed with:
flatpak run --command=flatpak-builder-lint org.flatpak.Builder --exceptions repo repo
in dir /srv/buildbot/worker/build-x86_64-1/build (timeout 1200 secs)
watching logfiles {}
argv: b'flatpak run --command=flatpak-builder-lint org.flatpak.Builder --exceptions repo repo'
using PTY: False
{
"errors": [
"appstream-missing-developer-name"
],
"warnings": [
"appstream-summary-too-long",
"appstream-screenshot-missing-caption"
]
}
Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter
program finished with exit code 1
elapsedTime=54.274905
|
Started test build 96692 |
anarcat
added a commit
to anarcat/supersonic
that referenced
this pull request
Jan 30, 2024
It seems this is necessary in Flatpaks now. I have a build that failed with:
```
flatpak run --command=flatpak-builder-lint org.flatpak.Builder --exceptions repo repo
in dir /srv/buildbot/worker/build-x86_64-1/build (timeout 1200 secs)
watching logfiles {}
argv: b'flatpak run --command=flatpak-builder-lint org.flatpak.Builder --exceptions repo repo'
using PTY: False
{
"errors": [
"appstream-missing-developer-name"
],
"warnings": [
"appstream-summary-too-long",
"appstream-screenshot-missing-caption"
]
}
Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter
program finished with exit code 1
elapsedTime=54.274905
```
... interestingly, that is marked as "warning" in the above
documentation:
https://docs.flathub.org/docs/for-app-authors/linter/#appstream-missing-developer-name
... but is reported as an error now. Even worse, the tag is
deprecated:
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer_name
I tried to fix it by vendoring this fixed version in the flatpak,
we'll see how that goes:
flathub/io.github.dweymouth.supersonic#62 (comment)
|
filed flathub-infra/flatpak-builder-lint#273 about the linter SNAFU. |
|
Build 96692 successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file shipped upstream tries to execute supersonic-desktop, which we do not have.
We also use the --set-icon shortcut to resolve any possible ambiguity with multiple --set-key options. I think multiples are allowed, but it seems prettier (and shorter) that way anyway.
Closes: dweymouth/supersonic#323