tests/usb: Skip the removal tests when the UMockdev version is too old #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swick
force-pushed
the
wip/test-latest-umockdev
branch
from
1827e0d to
306af18
Compare
|
This would close #1528 |
hfiguiere
reviewed
Jan 7, 2025
We disabled the test in CI because the tests were failing but we didn't understand why in 06a5e50 ("test: Disable USB removal test in a container") It turns out that UMockdev simply didn't send the remove event before version 0.18.4. Let's change the skip condition to actually check for the right thing instead of just disabling it in CI. This means that the test will run in CI once ubuntu:latest does have the right version. Closes flatpak#1528
swick
force-pushed
the
wip/test-latest-umockdev
branch
from
306af18 to
881756a
Compare
GeorgesStavracas
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disabled the test in CI because the tests were failing but we didn't understand why in
06a5e50 ("test: Disable USB removal test in a container")
It turns out that UMockdev simply didn't send the remove event before version 0.18.4. Let's change the skip condition to actually check for the right thing instead of just disabling it in CI. This means that the test will run in CI once ubuntu:latest does have the right version.