Make verify compatible with workspace inheritance #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Feb 5, 2024
|
I'll try and have a look at this PR tomorrow. In any case, thank you so much for the PR |
foresterre
requested changes
Feb 8, 2024
Sure thing, reverted 👍 |
foresterre
approved these changes
Feb 9, 2024
|
Thanks! |
This was referenced Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #590
Fix
verifyto allow parsingrust-versionwhich is inherited from workspace.I focus only on verify here as that is the use case I was after, but also to try limit changes. Not sure what other changes might be needed in codebase at the moment to fully close the ticket.