FIO-7528: Revert FIO-4405: fixed an issue where walidation error displays with empty value even if it is not required (#4746)

[lane-formio]

This reverts commit 3a8d7d6.

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7528

Description

There is a "shouldSkipValidation" function that checks for, among other things, whether or not the following conditions are satisfied:

(A) there is a custom validation

(B) the dataValue of the component is truthy

(C) the component is required

if A && !B && !C, the component will skip validating. In this case, since the value of an un-blurred select component is "", it is falsy and satisfies A && !B && !C. I'm not sure why this was introduced (I imagine to ensure that empty values that aren't required don't get validated) but we may need to reexamine our thinking behind this. In the meantime, the only workaround I can think of is to both set the field to required and maintain the custom validation, so both are ensured to run.

Here's the line in question:

formio.js/src/components/_classes/component/Component.js

Line 3325 in 51f82ab

() => this.component.validate.custom && !this.dataValue && !this.component.validate.required,

from this commit: formio.js: //github FIO-4405: fixed an issue where walidation error displays with empty value even if it is not required

Checklist:

• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (if applicable)
• My changes generate no new warnings
• My changes include tests that prove my fix is effective (or that my feature works as intended)
• New and existing unit/integration tests pass locally with my changes
• Any dependent changes have corresponding PRs that are listed above