Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7528: Revert FIO-4405: fixed an issue where walidation error displays with empty value even if it is not required (#4746) #5398

Merged
merged 1 commit into from
Nov 7, 2023
Merged

FIO-7528: Revert FIO-4405: fixed an issue where walidation error displays with empty value even if it is not required (#4746) #5398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/components/_classes/component/Component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3321,8 +3321,6 @@ export default class Component extends Element {

shouldSkipValidation(data, dirty, row) {
const rules = [
// Do not check custom validation for empty data if it is not required
() => this.component.validate.custom && !this.dataValue && !this.component.validate.required,
// Force valid if component is read-only
() => this.options.readOnly,
// Do not check validations if component is not an input component.
Expand Down