Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of coverage in gha #2175

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Fix use of coverage in gha #2175

merged 5 commits into from
Jan 9, 2025

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Jan 9, 2025

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@tcompa tcompa linked an issue Jan 9, 2025 that may be closed by this pull request
@tcompa tcompa marked this pull request as ready for review January 9, 2025 07:51
Copy link

github-actions bot commented Jan 9, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.4 10.1 0.93 0.6 0.6
power 404.1 404.6 1.00 366.2 366.2
dataset 148.5 151.7 0.98 134.0 134.0
project 42.4 43.3 0.98 47.2 47.2
job 28.7 29.1 0.99 32.4 32.4

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.0 6.4 0.94 2.2 2.2
power 136.0 137.8 0.99 652.2 652.2
dataset 142.8 143.4 1.00 905.2 905.2
project 45.3 45.2 1.00 283.8 283.8
job 39.7 39.5 1.01 224.9 224.9

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.7 7.2 1.07 0.1 0.1
power 7.2 7.4 0.97 0.1 0.1
dataset 6.9 7.1 0.97 0.1 0.1
project 8.6 8.6 1.00 2.3 2.3
job 6.8 6.9 0.99 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.7 6.2 0.92 0.8 0.8
power 5.6 6.1 0.92 0.8 0.8
dataset 5.8 6.4 0.91 0.8 0.8
project 5.5 5.9 0.93 0.8 0.8
job 5.7 6.0 0.95 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.9 7.4 0.93 1.6 1.6
power 6.8 7.2 0.94 1.6 1.6
dataset 6.8 7.2 0.94 1.6 1.6
project 6.8 6.7 1.01 1.6 1.6
job 6.8 6.7 1.01 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.6 10.5 1.01 0.8 0.8
power 24.2 24.1 1.00 29.1 29.1
dataset 18.2 18.1 1.01 16.7 16.7
project 22.1 21.4 1.03 21.0 21.0
job 11.4 10.6 1.08 0.8 0.8

POST /api/v2/project/3/dataset/403/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 148.5 147.4 1.01 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.9 4.5 1.09 0.2 0.2
power 4.7 4.3 1.09 0.2 0.2
dataset 4.7 4.4 1.07 0.2 0.2
project 4.6 4.4 1.05 0.2 0.2
job 4.8 4.3 1.12 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 273.8 272.2 1.01 0.2 0.2

Copy link

github-actions bot commented Jan 9, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

@tcompa tcompa merged commit 5dfaf4a into main Jan 9, 2025
18 checks passed
@tcompa tcompa deleted the 2152-fix-use-of-coverage-in-gha branch January 9, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix use of coverage in GHA
1 participant