Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin/feature/acceleration limiter #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ActualSkinwalker
Copy link
Collaborator

@ActualSkinwalker ActualSkinwalker commented Nov 21, 2023

Added method applyCircularDeadband to ControlsUtilities and modified the usage of ControlsUtilities in DriveCommand to use ternary expressions.

Added the applyCircularDeadband() method to ControlsUtilities

Modified DriveCommand to declare nextXSpeed, nextYSpeed, and nextThetaSpeed using ternary expressions.
…onLimiter

Origin/feature/acceleration limiter
@T99 T99 self-requested a review November 21, 2023 20:54
@T99 T99 self-assigned this Nov 21, 2023
@T99 T99 added the enhancement New feature or request label Nov 21, 2023
Copy link
Member

@T99 T99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the requested changes and let me know once they are live on this PR.

src/main/java/frc/robot/commands/DriveCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/ControlsUtilities.java Outdated Show resolved Hide resolved
Reverted changes to Drive command, changed circular deadband method to return a boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants