fix red potion bottle

[balloondude2]

Red Potion bottle was always going on the first bottle slot. This corrects it to go on the first open bottle slot.

Also adds the convert stuff for the Red Potion Bottle.

I tried changing the itemId for RI_BOTTLE_RED_POTION to ITEM_LONGSHOT instead, but that made the notification icon a Longshot. So I opted for the entry in GiveItem.cpp

Build Artifacts

• 2ship-linux.zip
• 2ship-windows.zip
• 2ship-mac.zip

[Eblo]

I first confirmed the issue without this fix; ITEM_RED_POTION indeed overwrites the first bottle slot even if something is there. I then tested the fix, which correctly adds a new bottle even if other bottles are already obtained. ITEM_LONGSHOT checks out here:

2ship2harkinian/mm/src/code/z_parameter.c

Lines 3879 to 3888 in 5bf3e04

	} else if (item == ITEM_LONGSHOT) {
	slot = SLOT(item);
	for (i = BOTTLE_FIRST; i < BOTTLE_MAX; i++) {
	if (gSaveContext.save.saveInfo.inventory.items[slot + i] == ITEM_NONE) {
	gSaveContext.save.saveInfo.inventory.items[slot + i] = ITEM_POTION_RED;
	return ITEM_NONE;
	}
	}
	return item;

The icon in the textbox and popup correctly displays the red potion bottle as well. Everything looks good here.