Rando: Add Checks for Milk Bar NPC Shop

[JoshSanch]

Implemented such that the checks are reobtainable when starting a new cycle, and the milk refills offered will become available once the checks are purchased on the same time cycle.

Some of the logic here could probably be used to set the prices to Tingle's randomized shop options as well.

YouTube link showing correct behavior across time cycles: https://youtu.be/FWCFyR2F8Xk

Build Artifacts

• 2ship-linux.zip
• 2ship-windows.zip
• 2ship-mac.zip

[Patrick12115]

Everything looks good in game from what I can tell!

[Eblo]

The player cannot proceed to the purchase dialog if they do not have at least one empty bottle. In vanilla this makes sense because the items are always bottled. I think logic should be updated to require a bottle for these checks.

As a quick and dirty test, I tried proceeding to the purchase dialog and then edited my inventory to have no empty bottles, then purchased the vanilla item. The shop forcibly writes a milk bottle into the player's inventory even without a bottle to start with so I don't think removing the bottle requirement is a good idea.

Edit: Upon further discussion, maybe the answer is to remove the bottle condition, and then use the RI milk/chateau refills instead of the vanilla ones. Thoughts?

[JoshSanch]

I agree with that approach.

[JoshSanch]

This is currently held up by me trying to get the normal Milk/Chateau bottle check to happen upon purchasing the vanilla purchases, instead of before. Haven't figured out the best approach yet.

[JoshSanch]

I've found a solution that I'm happy with but it contains some minor additions to the arguments passed to the VB_EXEC_MSG_EVENT Should hook that may require discussion. I will open a new PR to make it easier to document that review/discussion.