Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start-proxy: Remove unusued proxy_password input #2733

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

marcogario
Copy link
Contributor

While the proxy supports a password for basic authentication, we are not currently using this feature.

The change remove the associated code to avoid having code we are not using and is rarely tested. The change is small enough that, if we ever change our minds, we can easily revert.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@marcogario marcogario marked this pull request as ready for review January 27, 2025 20:24
@marcogario marcogario requested a review from a team as a code owner January 27, 2025 20:24
@marcogario marcogario merged commit 5f4f998 into main Jan 28, 2025
525 checks passed
@marcogario marcogario deleted the marcogario/remove_proxy_password branch January 28, 2025 08:59
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
8 tasks
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants