Solitreo: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added

[eliheuer]

ff1a2f7: [gftools-packager] Solitreo: Version 1.000; ttfautohint (v1.8.4.7-5d5b) added

• Solitreo Version 1.000; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/ladinoprojects/solitreo at commit ladinoprojects/solitreo@fd2871e.

[gf-bot]

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks

ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

• ℹ INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

  And these are the most common STAT axis orderings:
  [code: summary]

[19] Solitreo-Regular.ttf

⚠ WARN: URLs on DESCRIPTION file must not display http(s) prefix. (com.google.fonts/check/description/urls)

• ⚠ WARN Please remove the "http(s)://" prefix from the link text "https://github.com/ladinoprojects/solitreo" [code: prefix-found]

⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)

• ⚠ WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
  [code: unknown]

⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)

• ⚠ WARN Family not found via Google Fonts API. [code: not-found]

⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)

• ⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)

• ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

  • uni05D1 + uni05F3

  • uni05F3 + quoteright

  • quoteright + quotesingle

  • uni05D2 + uni05F3

  • uni05F3 + uni05D5

  • uni05D5 + uni05F3

  • uni05F3 + uni05D9

  • uni05D9 + quoteright

  • quoteright + uni05D5

  • uni05D5 + quoteright

  • And 34 more.

Use -F or --full-lists to disable shortening of long lists. [code: lacks-kern-info]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)

• ⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)

• ⚠ WARN It seems that Nathan Gross is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
• ⚠ WARN It seems that Bryan Kirschen is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

• ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

• ⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:

  • brevecombcy

  • eight.dnom

  • eight.numr

  • five.dnom

  • five.numr

  • four.dnom

  • four.numr

  • nine.dnom

  • nine.numr

  • one.dnom

  • And 13 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)

• ⚠ WARN This font has a 'Soft Hyphen' character (codepoint 0x00AD) which is supposed to be zero-width and invisible, and is used to mark a hyphenation possibility within a word in the absence of or overriding dictionary hyphenation. It is mostly an obsolete mechanism now, and the character is only included in fonts for legacy codepage coverage. [code: softhyphen]
• ⚠ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: percent	Contours detected: 4	Expected: 5

- Glyph name: Q	Contours detected: 3	Expected: 2

- Glyph name: q	Contours detected: 1	Expected: 2

- Glyph name: uni2076	Contours detected: 1	Expected: 2

- Glyph name: uni2086	Contours detected: 1	Expected: 2

- Glyph name: Q	Contours detected: 3	Expected: 2

- Glyph name: percent	Contours detected: 4	Expected: 5 

- And Glyph name: q	Contours detected: 1	Expected: 2

[code: contour-count]

⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)

• ⚠ WARN No dotted circle glyph present [code: missing-dotted-circle]

ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)

• ℹ INFO Found a git repo URL: https://github.com/itfoundry/kalam [code: url-found]
• ℹ INFO Found a git repo URL: https://github.com/ladinoprojects/solitreo [code: url-found]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)

• ℹ INFO Hinting filesize impact:

	ofl/solitreo/Solitreo-Regular.ttf
Dehinted Size	60.6kb
Hinted Size	88.1kb
Increase	27.6kb
Change	45.5 %
[code: size-impact]

ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)

• ℹ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]

ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)

• ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)

• ℹ INFO Version string is: "Version 1.000; ttfautohint (v1.8.4.7-5d5b)"
  The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
  "Version 1.3; git-0d08353-release" [code: bad-format]

ℹ INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)

• ℹ INFO No sample_glyphs on METADATA.pb [code: no-samples]

ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

• ℹ INFO This font contains the following optional tables:

  • cvt

  • fpgm

  • loca

  • prep

  • GPOS

  • GSUB

  • And gasp [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)

• ℹ INFO ofl/solitreo [code: family-path]

### Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	0	11	55	9	152	0
0%	0%	5%	24%	4%	67%	0%

Note: The following loglevels were omitted in this report:

• SKIP
• PASS
• DEBUG

[RosaWagner]

@eliheuer can you confirm the 2 scripts are scaled correctly to match with each other?

[eliheuer]

@RosaWagner Yes, I did the best I could trying to match the two scripts, but I'm sure I could have done a better job somehow, and If there is something specific I could have done better I'm open to suggestions and could update the source.

It's a very strange style of Hebrew, mostly small characters, but with a few large loopy ones, so it was hard to match with the Latin. There were some Latin glyphs included by the original designer, so I mostly tried to match the Latin with those.

This is what it should look like in use:

[eliheuer]

@davelab6 I have a lot of free time this week, if there is anything that you would have done differently with this project please let me know and I will do it.

I'm also open to the idea that this font just won't work on Google Fonts and the PR should be closed, the upstream project can still use the font even if it is not on Google Fonts.

[eliheuer]

I'm working on a new version of this font with improved proportions between the Hebrew and Latin, will update this PR with that hopefully next week.

[vv-monsalve]

Hi @eliheuer

I'm working on a new version of this font with improved proportions between the Hebrew and Latin, will update this PR with that hopefully next week.

Do you have an estimated date for updating the PR? Content editors are asking about this project since I understand they are preparing an article for the font.

[eliheuer]

@vv-monsalve @RosaWagner The only thing holding this up is that RTL kerning will not build with the Google Fonts Project Template GitHub Actions, see the issues here:

1. Support Glyphs3 RTL kerning googlefonts/glyphsLib#778
2. WIP: Support Glyphs3-style glyph data incl. writing direction googlefonts/glyphsLib#818

I'm going to try to make a new release without RTL kerning today and update this PR, so this should be ready to review soon, just keep in mind that the Hebrew will have many issues due to the RTL kerning being broken. Thanks!

[eliheuer]

Updated

Solitreo: Version 1.100; ttfautohint (v1.8.4.7-5d5b) added

---

a3d4088: [gftools-packager] Solitreo: Version 1.100; ttfautohint (v1.8.4.7-5d5b) added

• Solitreo Version 1.100; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/ladinoprojects/solitreo.git at commit ladinoprojects/solitreo@9b03239.

[eliheuer]

@RosaWagner @vv-monsalve I made a v1.100 release in the upstream repo and this is now ready for review again.

In order to get the RTL kerning to work, I had to build the font locally using GlyphsLib a branch called support_glyphs3_rtl_kerning-3, but the font should build fine with GitHub Actions once RTL kerning is supported in the main branch of GlyphsLib.

Besides RTL kerning the v1.100 release also fixes the scaling issues between the Hebrew and Latin, plus various other bug fixes and some additional Latin kerning as well.

Thanks! Let me know if any more updates are needed. I'm looking into why the GF-QA check is failing now.

[RosaWagner]

LGTM

Fontbakery report

Fontbakery version: 0.8.11a8

⚠ WARN: URLs on DESCRIPTION file must not display http(s) prefix. (com.google.fonts/check/description/urls)

• ⚠ WARN Please remove the "http(s)://" prefix from the link text "https://github.com/ladinoprojects/solitreo" [code: prefix-found]

⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)

• ⚠ WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
  [code: unknown]

⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)

• ⚠ WARN Family not found via Google Fonts API. [code: not-found]

⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)

• ⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)

• ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

  • uni05D1 + uni05F3

  • uni05F3 + quoteright

  • quoteright + quotesingle

  • uni05D2 + uni05F3

  • uni05F3 + uni05D5

  • uni05D5 + uni05F3

  • uni05F3 + uni05D9

  • uni05D9 + quoteright

  • quoteright + uni05D5

  • uni05D5 + quoteright

  • And 34 more.

Use -F or --full-lists to disable shortening of long lists. [code: lacks-kern-info]

⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)

• ⚠ WARN It seems that Nathan Gross is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
• ⚠ WARN It seems that Bryan Kirschen is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

• ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

• ⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:

  • eight.dnom

  • eight.numr

  • five.dnom

  • five.numr

  • four.dnom

  • four.numr

  • nine.dnom

  • nine.numr

  • one.dnom

  • one.numr

  • And 13 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)

• ⚠ WARN This font has a 'Soft Hyphen' character (codepoint 0x00AD) which is supposed to be zero-width and invisible, and is used to mark a hyphenation possibility within a word in the absence of or overriding dictionary hyphenation. It is mostly an obsolete mechanism now, and the character is only included in fonts for legacy codepage coverage. [code: softhyphen]
• ⚠ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: percent	Contours detected: 4	Expected: 5

- Glyph name: Q	Contours detected: 3	Expected: 2

- Glyph name: q	Contours detected: 1	Expected: 2

- Glyph name: uni2076	Contours detected: 1	Expected: 2

- Glyph name: uni2086	Contours detected: 1	Expected: 2

- Glyph name: Q	Contours detected: 3	Expected: 2

- Glyph name: percent	Contours detected: 4	Expected: 5 

- And Glyph name: q	Contours detected: 1	Expected: 2

[code: contour-count]

⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)

• ⚠ WARN No dotted circle glyph present [code: missing-dotted-circle]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	0	10	62	8	152	0
0%	0%	4%	27%	3%	65%	0%

Note: The following loglevels were omitted in this report:

• SKIP
• INFO
• PASS
• DEBUG

Proof.zip