[chore] Update manifests post fea-rs merge #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
reviewed
Oct 25, 2023
fea-rs/Cargo.toml
Outdated
| diff = { version = "0.1.12", optional = true } | ||
| rayon = { version = "1.6", optional = true } | ||
| serde = { version = "1.0.147", features = ["derive"], optional = true } | ||
| serde_json = {version = "1.0.87", optional = true } | ||
| thiserror = "1.0.37" | ||
| clap = { version = "4.0.32", features = ["derive"], optional = true } |
There was a problem hiding this comment.
I think several more can move to workspace if we follow the current practice of doing so as soon as more than one crate uses something:
- fontc also uses both clap and rayon so they should move
- serde is in the workspace
- ufo2fontir uses norad
There was a problem hiding this comment.
the issue is that in fea-rs these are optional, whereas they aren't in the other crates, so I don't think this works?
There was a problem hiding this comment.
You can combine workspace and optional, https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace
rsheeter
approved these changes
Oct 25, 2023
cmyr
force-pushed
the
consolidate-dependencies
branch
2 times, most recently
from
47e86b6 to
3ff15ef
Compare
This makes fea-rs use the workspace deps where possible, and makes fontbe use the local fea-rs. It also makes a few other updates to update paths & urls in fea-rs/Cargo.toml, and it bumps a few out of date dependencies.
cmyr
force-pushed
the
consolidate-dependencies
branch
from
3ff15ef to
8316844
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes fea-rs use the workspace deps where possible, and makes fontbe use the local fea-rs.
It also makes a few other updates to update paths & urls in fea-rs/Cargo.toml, and it bumps a few out of date dependencies.