-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GlyphsBackend writable #76
base: main
Are you sure you want to change the base?
Conversation
All good so far 👍 |
@justvanrossum
Would be great if we could talk about it tomorrow: c4efd49 |
@justvanrossum So, the whole formatting with This is the reason why I implemented Via
I think this might be better and is probably closer to your original idea? |
…ust saveFileWithGsFormatting
# 1. convert VariableGlyph to GSGlyph (but start with a copy of the original) # 2. serialize to text with glyphsLib.writer.Writer(), using io.StringIO or io.BytesIO # 3. parse stream into "raw" object # 4. replace original "raw" object with new "raw" object # 5. write whole file with openstep_plist
ee36016
to
6d8e783
Compare
because it's done by Just's openstep-plist
Our openstep-plist fork now also fixes the binary data formatting, so the last regex-based workaround can be removed. |
Justs openstep-plist takes care of binary_spaces, so need of extra function.
GlyphsApp will add an empty layer if one is missing.
This fixes #75.
This also fixes #79.
I added all missing 'put' methods from WritableFontBackend as stubs.
This is a draft PR for getting feedback early.