Code

Make GlyphsBackend writable#76

Code

Open

ollimeier wants to merge 58 commits intomaingooglefonts/fontra-glyphs:mainfrom issue-75-make-GlyphsBackend-writablegooglefonts/fontra-glyphs:issue-75-make-GlyphsBackend-writableCopy head branch name to clipboard

+820-63

Commits

Commits on Jan 22, 2025

• Add all missing 'put' methods from WritableFontBackend as stubs

  ollimeier

  committed
  de23e83

  Copy full SHA for de23e83

• GlyphsBackend work in progress: two options for discussion

  ollimeier

  committed
  35015d3

  Copy full SHA for 35015d3

• Remove option 2, use some better options for openstep_plist.dump, adjust saveFileWithGsFormatting

  ollimeier

  committed
  417d2fd

  Copy full SHA for 417d2fd

• Rework putGlyph based on brainstorming together with Just

  Show description for 1f25bbb
  ollimeier

  committed
  1f25bbb

  Copy full SHA for 1f25bbb

• Add A-cy for testing

  ollimeier

  committed
  e8ef42a

  Copy full SHA for e8ef42a

• get the right glyphspackage glyph file name

  ollimeier

  committed
  e2a2626

  Copy full SHA for e2a2626

• Add _findAndReplaceGlyph

  ollimeier

  committed
  6dcbf38

  Copy full SHA for 6dcbf38

• openstep_plist: Fix order issue with toOrderedDict

  ollimeier

  committed
  d8ac61e

  Copy full SHA for d8ac61e

• Remove _findAndReplaceGlyph idea

  ollimeier

  committed
  354e7fd

  Copy full SHA for 354e7fd

• Commit current stage.

  ollimeier

  committed
  bf1bfb9

  Copy full SHA for bf1bfb9

• Use pen for drawing

  ollimeier

  committed
  c7a66a4

  Copy full SHA for c7a66a4

• Adding some comments

  ollimeier

  committed
  62d0e93

  Copy full SHA for 62d0e93

• Add A-cy also to Glyphs 2 and 3 file for unittests

  ollimeier

  committed
  f76ea61

  Copy full SHA for f76ea61

• Rework unittests and fix issue based on self.parsedGlyphNames

  ollimeier

  committed
  b560a89

  Copy full SHA for b560a89

• Fixing the special layer issue with adding a gsLayer.layerId mapping to customData

  ollimeier

  committed
  fc5469a

  Copy full SHA for fc5469a

• Extend unittest with test_deleteLayer

  ollimeier

  committed
  eaf8559

  Copy full SHA for eaf8559

• Add unittest test_addLayer (work in progress)

  ollimeier

  committed
  53a106d

  Copy full SHA for 53a106d

• Add support for 'intermediate layer'

  ollimeier

  committed
  c27e22e

  Copy full SHA for c27e22e

• putGlyph including components and anchors + unittests

  ollimeier

  committed
  e343a3d

  Copy full SHA for e343a3d

• Adjust comments, restructure a bit + more unittests

  ollimeier

  committed
  b43907a

  Copy full SHA for b43907a

• Fix missing comma and remove 'local hack'

  ollimeier

  committed
  f6a6728

  Copy full SHA for f6a6728

• Rework gsFormatting

  ollimeier

  committed
  7afe3fa

  Copy full SHA for 7afe3fa

• Extend Readme file

  ollimeier

  committed
  f6fe46c

  Copy full SHA for f6fe46c

• Move getGlyphspackageGlyphFileName to utils and add unittest

  ollimeier

  committed
  14144d3

  Copy full SHA for 14144d3

• Move comment and make it a bit more clear.

  ollimeier

  committed
  6d8e783

  Copy full SHA for 6d8e783

• Remove seenLayerIDs. Use 'new' layerName (equal to layerId)

  ollimeier

  committed
  3a210e6

  Copy full SHA for 3a210e6

• Update test data "A-cy" + fix test_getGlyph: bug in GlyphsApp 2 file

  ollimeier

  committed
  698722f

  Copy full SHA for 698722f

• Replace getGlyphspackageGlyphFileName with userNameToFileName (fonttools)

  ollimeier

  committed
  a40a429

  Copy full SHA for a40a429

• Refactor and fix unittests

  ollimeier

  committed
  f25b1b6

  Copy full SHA for f25b1b6

• rework _writeRawGlyph (dumps)

  ollimeier

  committed
  1e0ae6a

  Copy full SHA for 1e0ae6a

• Remove resolved comment

  ollimeier

  committed
  e4e097e

  Copy full SHA for e4e097e

• Fix variable name, add and remove some comments

  ollimeier

  committed
  f1fc7e0

  Copy full SHA for f1fc7e0

Commits on Jan 23, 2025

• Improve getAssociatedMasterId + unittests

  ollimeier

  committed
  7d56bac

  Copy full SHA for 7d56bac

• Raise NotImplementedError for stubs

  ollimeier

  committed
  248fdf1

  Copy full SHA for 248fdf1

• Update self.glyphMap within putGlyph

  ollimeier

  committed
  00753f9

  Copy full SHA for 00753f9

• replace gsFormatting with convertMatchesToTuples

  ollimeier

  committed
  834dfe7

  Copy full SHA for 834dfe7

• Fix customBinaryData formatting with regEx

  ollimeier

  committed
  a7fbd45

  Copy full SHA for a7fbd45

• Adding guideline to get- and putGlyph

  ollimeier

  committed
  d41b0b2

  Copy full SHA for d41b0b2

• Removing toOrderedDict, not necessary anymore

  Show description for 2161e6d
  ollimeier

  committed
  2161e6d

  Copy full SHA for 2161e6d

• Updating fontra data, because of missing guideline

  ollimeier

  committed
  33840a3

  Copy full SHA for 33840a3

• Raise error when trying to delete a master layer. Remove numbers from comments.

  ollimeier

  committed
  3568338

  Copy full SHA for 3568338

• Update workflow pytest.yml with Just's openstep-plist

  ollimeier

  committed
  0d558d8

  Copy full SHA for 0d558d8

• Return copy, as callers may mutate the result. This fixes googlefonts/fontra#1979

  justvanrossum

  committed
  5a0b821

  Copy full SHA for 5a0b821

• Better deepcopy the glyphMap, as clients may mutate

  justvanrossum

  committed
  4ed0ac5

  Copy full SHA for 4ed0ac5

Commits on Jan 28, 2025

• Remove fixCustomBinaryDataFormatting and fix some unittests

  Show description for eb1a70c
  ollimeier

  committed
  eb1a70c

  Copy full SHA for eb1a70c

• Don't raise error if some deletes master layer

  Show description for e1452c1
  ollimeier

  committed
  e1452c1

  Copy full SHA for e1452c1

• Removing fixCustomBinaryDataFormatting

  ollimeier

  committed
  1ec4a25

  Copy full SHA for 1ec4a25

Commits on Jan 31, 2025

• Removing Just's version of openstep-plist because it's part of the official now

  ollimeier

  committed
  b00dd76

  Copy full SHA for b00dd76

Commits on Feb 4, 2025

• Fix issue with fontra source name

  ollimeier

  committed
  2f99a3a

  Copy full SHA for 2f99a3a

Commits on Feb 5, 2025

• Fix round-trip issue with adding non-master-layer

  ollimeier

  committed
  df72ef5

  Copy full SHA for df72ef5

• Fix round-trip unittest + fix issue with smartcomonent

  ollimeier

  committed
  3d8a990

  Copy full SHA for 3d8a990

• duplicate glyph and add as new glyph

  ollimeier

  committed
  fa207bf

  Copy full SHA for fa207bf

• Create new glyph + unittest

  ollimeier

  committed
  e0bc5ca

  Copy full SHA for e0bc5ca

• figure out if master layer based on location + use 'Default' for unittest

  ollimeier

  committed
  a39e88a

  Copy full SHA for a39e88a

• Rework gsLocation

  ollimeier

  committed
  af1e72d

  Copy full SHA for af1e72d

• Update Fontra test data (dense location)

  ollimeier

  committed
  b458ba9

  Copy full SHA for b458ba9

• Update getLocationFromSources

  ollimeier

  committed
  36127f9

  Copy full SHA for 36127f9

• Fix typing

  justvanrossum

  committed
  43ebf28

  Copy full SHA for 43ebf28