-
Notifications
You must be signed in to change notification settings - Fork 10
Htsget BAM to implementation for file interface #49
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLA signed |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
i'm the only one who wrote code |
@gkelly @deflaux @google-admin |
Thanks for reaching out. I took a look and, after discussing it with our product manager (@sheffi), this doesn't look like it really aligns with our product roadmap. This server is intended as an implementation of HTSGET on top of Google's Cloud technologies. A local file-based implementation isn't something that we are looking to add to this product at this time. If you need this functionality for a project of your own and would like to use our server as a foundation, I suggest keeping your changes in a fork that can be used by other people with similar problems. Thanks, |
I created a file interface for htsget incase you're using a file system instead of google cloud
I didn't change the previous code and I didn't add documentation for it (pretty self explanatory)
If this pull request gets accepted, I'll add modifications to the README
I'm looking into the cram implementation in the coming future