FEA - Added motor function: run_to_position. (Without speed) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed to wrong directory.
gpdaniels
reviewed
Aug 9, 2022
simulator/api/spike/hub.py
Outdated
Comment on lines
152
to
160
| class PortRef(): | ||
| pass | ||
|
|
||
|
|
||
| # dictionary of widgets to their name and class | ||
| WIDGET_LOOKUP = {None: ['motor', None], | ||
| "MotorLargeWidget": ['motor', Motor()], | ||
| "MotorSmallWidget": ['motor', Motor()], | ||
| } |
There was a problem hiding this comment.
One concern I have is that these don't exist in the hub api. So if someone starts using the file to develop a script for the hub they may see it, use it, and then be frustrated when it doesn't work on the device itself.
I think ideally all complex functionality should live in the simulator.py script which is then imported by this file.
Refactored.
|
Refactored the code as you have suggested. |
Refactor
FEA - Added run_for_degrees.
No longer scatter dead Accessory windows on clicking on another port.
|
Looks cool! :D Exited to see what comes next! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.