-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEA - Added motor function: run_to_position. (Without speed) #33
Open
DMB-rgb
wants to merge
14
commits into
gpdaniels:master
Choose a base branch
from
DMB-rgb:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3a4a26b
Add files via upload
DMB-rgb 7da03b1
Add files via upload
DMB-rgb 6dbf07d
Delete hub.py
DMB-rgb ec8a005
Add files via upload
DMB-rgb d646293
Add files via upload
DMB-rgb fb0177f
RFR large motor and medium motor with base motor
DMB-rgb e6f366c
FEA - Added selection of accessory.
DMB-rgb 7dd9e80
TDY - Use more appropriate names.
DMB-rgb 33a8803
FIX - Now keep a reference .my_port in the accessory of which port it…
DMB-rgb b539dba
FIX - There is now a motor for each motor accessory selected.
DMB-rgb 8e0e2fb
TDY - make instance using type and comment out printf's
DMB-rgb bde0b52
FEA - Added speed to run to position.
DMB-rgb 3d7c451
FEA - Add run for a time at speed.
DMB-rgb d1e22c1
FIX - One defining window is to be active.
DMB-rgb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern I have is that these don't exist in the hub api. So if someone starts using the file to develop a script for the hub they may see it, use it, and then be frustrated when it doesn't work on the device itself.
I think ideally all complex functionality should live in the simulator.py script which is then imported by this file.