-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor style improvements found by cppcheck #2766
Conversation
Thank you for the PR, but we are not interested for these variable name changing, for example |
Just so I know are you interested in the function prototypes matching the functions ? Would you like to cherry pick the break; to be inside the #if ? |
Could you elaborate, is there any mismatched prototype ?
Yes please. |
In tusb_fifo.h we currently have : This is super minor but the PR intended to make the second parameter match. |
Didn't notice that, please change the prototype to use Speaking of which the project doesn't have a naming convention yet... |
Minor style improvements found by cppcheck.