Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor style improvements found by cppcheck #2766

Closed
wants to merge 8 commits into from
Closed

Minor style improvements found by cppcheck #2766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8027135
Merge pull request #1 from hathach/master
dp111 Aug 15, 2024
c34d5e7
Put break inside #if #endif
dp111 Aug 16, 2024
461a346
make function variables match prototypes
dp111 Aug 16, 2024
fc294f8
Merge pull request #2 from hathach/master
dp111 Aug 19, 2024
8353d86
Merge pull request #3 from hathach/master
dp111 Sep 1, 2024
6e28005
Merge pull request #4 from hathach/master
dp111 Sep 1, 2024
9f1a6b6
Revert "make function variables match prototypes"
dp111 Sep 1, 2024
37a5bd2
tusb_fifo.h : make prototype variables match functions ( found with c…
dp111 Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/common/tusb_fifo.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,8 @@ static void _ff_pull_n(tu_fifo_t* f, void* app_buf, uint16_t n, uint16_t rd_ptr,
// Read data wrapped part
if (wrap_bytes > 0) _ff_pull_const_addr(app_buf, ff_buf, wrap_bytes);
}
#endif
break;

#endif
default: break;
}
}
Expand Down
8 changes: 4 additions & 4 deletions src/common/tusb_fifo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,14 @@ void tu_fifo_config_mutex(tu_fifo_t *f, osal_mutex_t wr_mutex, osal_mutex_t rd_m
#define tu_fifo_config_mutex(_f, _wr_mutex, _rd_mutex)
#endif

bool tu_fifo_write (tu_fifo_t* f, void const * p_data);
uint16_t tu_fifo_write_n (tu_fifo_t* f, void const * p_data, uint16_t n);
bool tu_fifo_write (tu_fifo_t* f, void const * data);
uint16_t tu_fifo_write_n (tu_fifo_t* f, void const * data, uint16_t n);
#ifdef TUP_MEM_CONST_ADDR
uint16_t tu_fifo_write_n_const_addr_full_words (tu_fifo_t* f, const void * data, uint16_t n);
#endif

bool tu_fifo_read (tu_fifo_t* f, void * p_buffer);
uint16_t tu_fifo_read_n (tu_fifo_t* f, void * p_buffer, uint16_t n);
bool tu_fifo_read (tu_fifo_t* f, void * buffer);
uint16_t tu_fifo_read_n (tu_fifo_t* f, void * buffer, uint16_t n);
#ifdef TUP_MEM_CONST_ADDR
uint16_t tu_fifo_read_n_const_addr_full_words (tu_fifo_t* f, void * buffer, uint16_t n);
#endif
Expand Down