fix-2 #2
Open
fix-2 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
hifeful
commented
Jun 28, 2023
hifeful
commented
- MyMealsFragment.kt was reimplemented to use custom MVI with Flows instead of MVICore's solution
- Coroutines were added
- Other small fixes
…nstead of MVICore's solution - Coroutines were added - Other small fixes
lus-ence
reviewed
Jun 28, 2023
app/src/main/java/com/hifeful/mealmania/presentation/myMeals/MyMealsFragmentBinder.kt
Outdated
Show resolved
Hide resolved
| binding.bind(it, recentMealsAdapter, favouriteMealsAdapter) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Correct ✅
Just FYI: there is the alternative of Flow.flowWithLifecycle
app/src/main/java/com/hifeful/mealmania/presentation/myMeals/MyMealsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/hifeful/mealmania/presentation/myMeals/MyMealsViewModel.kt
Outdated
Show resolved
Hide resolved
| when (event) { | ||
| is MyMealsEvent.LoadRecentMeals -> mealsRepository.getRecentMeals() | ||
| .subscribeOn(Schedulers.computation()) | ||
| .observeOn(AndroidSchedulers.mainThread()) |
There was a problem hiding this comment.
When we have Rx and Coroutines together, we should convert Rx into Coroutine.
That way, we gonna have control of threads and easily debug and handle any errors.
👌 The known and checked solution of how to do this conversion is using suspendCoroutine:
suspendCoroutine { continuation ->
try {
continuation.resume(mealsRepository.getRecentMeals().blockingGet())
} catch (cancellation: CancellationException) {
continuation.resumeWithException(cancellation)
} catch (failure: Exception) {
// handle error somehow (for instance, map to custom error type)
continuation.resumeWithException(cancellation)
}
}
There was a problem hiding this comment.
No action is required for now
As threading will be in another module soon
Closed
- fixes in MyMealsViewModel.kt
epam-alyse
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.