Store canvas terms info on the database #6969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
force-pushed
the
store-term-info
branch
from
8ffb6e4 to
d262688
Compare
This was referenced Jan 28, 2025
Merged
marcospri
force-pushed
the
store-term-info
branch
from
d262688 to
a862000
Compare
marcospri
force-pushed
the
store-term-info
branch
from
a862000 to
1b3020d
Compare
marcospri
force-pushed
the
store-term-info-model
branch
from
e0d995d to
5da01a0
Compare
marcospri
force-pushed
the
store-term-info
branch
from
1b3020d to
73c2e4b
Compare
marcospri
commented
Jan 28, 2025
| @@ -26,6 +29,13 @@ def __init__(self, v11: dict, v13: dict | None = None): | |||
| def v11(self): | |||
| return self | |||
|
|
|||
| def get_datetime(self, key: str) -> datetime | None: | |||
There was a problem hiding this comment.
We were doing this same thing for course dates.
Generalize it a bit and move it to LTIParams.
| @@ -431,22 +441,6 @@ def _get_copied_from_course(self, lti_params) -> Course | None: | |||
|
|
|||
| return None | |||
|
|
|||
| def _get_course_dates( | |||
marcospri
force-pushed
the
store-term-info-model
branch
from
5da01a0 to
88d64e4
Compare
marcospri
force-pushed
the
store-term-info
branch
from
73c2e4b to
6d3a54e
Compare
marcospri
force-pushed
the
store-term-info-model
branch
from
88d64e4 to
0e0768d
Compare
While we'll only get this information from some Canvas installs the new table and service code are LMS agnostic. We'll store the Canvas data for a while before exploring how to integrate other LMSes
marcospri
force-pushed
the
store-term-info
branch
from
6d3a54e to
5c4f3f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll start storing this data based on launches that contain the lastest Canvas configuration, which includes variables about terms.
This will allow us to build a backlog of courses with start and end dates.
We recently did a similar job to store course dates, which in Canvas means courses that don't belong to a term. In combination this commit this should give us coverage of all LTI1.3 courses for schools that have the most recent configuration.
See: #6941
Testing
https://hypothesis.instructure.com/courses/125/assignments/1833
Everything looks good, nothing gets created on the DB.
Launch an assignment that does send term information
https://hypothesis.instructure.com/courses/319/assignments/3308