Remove react-transition-group dependency
#2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o r/themeprovider-children-state-loss-fix
…ransition-group-removal
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team
mayank99
reviewed
Jan 21, 2025
apps/react-workshop/cypress-visual-screenshots/baseline/Toasts.test.ts-Informational.png
Outdated
Show resolved
Hide resolved
mayank99
reviewed
Jan 27, 2025
mayank99
reviewed
Jan 27, 2025
mayank99
approved these changes
Jan 28, 2025
smmr-dn
approved these changes
Jan 28, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prerequisite for #2387. Fixes #2199.
This PR removes the dependency to the now mostly unmaintained
react-transition-group. This has been our plan for a while now because of running into issues with it and having to find workarounds (e.g. #1835). Since React 19 has now removed the deprecatedfindDOMNode()thatreact-transition-groupmoving away from this package is needed to support React 19 in #2387.Affected components:
animate()function to implement the same animation in JS.There were some animations that used to work in previous v3 versions and also in v2. Some of these animations stopped working in the previous few versions before this PR. So, I just removed the code for those animations since they anyways weren't working even before this PR. Some of these animations include:
Table with subcomponent
v2.mov
v3.mov
SideNavigation with submenu
v2.mov
v3.mov
This PR also deprecates the
react-transition-grouprelated CSS classes:.iui-enter,.iui-enter-active,.iui-exit,.iui-exit-activesince they are no longer needed.Testing
Confirmed whenever react-transition-group was used or at least was intended to be used, there is no visual change after this PR. The only exception is where we purposefully removed the animation temporarily (Dialog/Modal exit animation).
Docs
Added minor react and css changesets.
It is minor for css because of class deprecations. It is a minor for react since
react-transition-groupcould be a dependency used in users' apps too and so could affect their dependency resolution. An additional reason is that theDialog/Modal's exit animation is removed temporarily.After PR TODO: