-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(duckdb): ensure that duckdb columns argument to read_csv accepts duckdb syntax not ibis syntax #10696
fix(duckdb): ensure that duckdb columns argument to read_csv accepts duckdb syntax not ibis syntax #10696
Conversation
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
ba8b94a
to
1fd9a4a
Compare
Apparently, this was intended to support ibis types in the mapping, so the only way I can see to address the issue without breaking existing code is to allow cc @amoeba |
…duckdb syntax not ibis syntax
I think this is probably better to break for 10.0 and use the behavior that's in this PR, which is that That is, the types are spelled the way duckdb spells them, not the way Ibis spells them. |
1fd9a4a
to
a020c14
Compare
I think this changes matches the behavior I'd expect so 👍 here. |
Fixes an issue where the input strings in the
columns
(andtypes
) argument toread_csv
assumed the input type strings are ibis types, whereas they are actually DuckDB types. Closes #10695.BREAKING CHANGE: The
duckdb
backend'sread_csv
method accepts only DuckDB types for the values components of thecolumns
andtypes
dictionary arguments. You may need need to adjust existing code. For example, the string"float64"
should be replaced with the string"double"
.