Add capStyle for Pie Charts #1832
Open
+97
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaNNeo
reviewed
Jan 6, 2025
| @@ -107,6 +118,7 @@ class PieChartData extends BaseChartData with EquatableMixin { | |||
| b.centerSpaceRadius, | |||
| t, | |||
| ), | |||
| capStyle: capStyle, | |||
There was a problem hiding this comment.
It should be capStyle: b.capStyle,
imaNNeo
reviewed
Jan 6, 2025
| @@ -401,3 +414,9 @@ class PieChartDataTween extends Tween<PieChartData> { | |||
| @override | |||
| PieChartData lerp(double t) => begin!.lerp(begin!, end!, t); | |||
| } | |||
|
|
|||
| enum CapStyle { | |||
There was a problem hiding this comment.
Please write a documentation above it. And it seems it is specially for PieChart. So I think it makes sense to add Pie prefix for it.
|
It feels weird in our PieChartSample 2. CleanShot.2025-01-06.at.21.21.58.mp4 |
|
Also you need to update the unit-tests and add new ones for your feature. |
|
@imaNNeo will do once I get the chance. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances Pie Charts that have non-null & non-zero
centerSpaceRadius. Fixes this issue: #1699Based on this PR #1698