-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capStyle for Pie Charts #1832
Open
bqubique
wants to merge
3
commits into
imaNNeo:main
Choose a base branch
from
bqubique:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−35
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,13 +31,19 @@ class PieChartData extends BaseChartData with EquatableMixin { | |
PieTouchData? pieTouchData, | ||
FlBorderData? borderData, | ||
bool? titleSunbeamLayout, | ||
}) : sections = sections ?? const [], | ||
CapStyle? capStyle, | ||
}) : assert( | ||
capStyle == null || centerSpaceRadius != null, | ||
'centerSpaceRadius must not be null if capStyle is provided', | ||
), | ||
sections = sections ?? const [], | ||
centerSpaceRadius = centerSpaceRadius ?? double.infinity, | ||
centerSpaceColor = centerSpaceColor ?? Colors.transparent, | ||
sectionsSpace = sectionsSpace ?? 2, | ||
startDegreeOffset = startDegreeOffset ?? 0, | ||
pieTouchData = pieTouchData ?? PieTouchData(), | ||
titleSunbeamLayout = titleSunbeamLayout ?? false, | ||
capStyle = capStyle ?? CapStyle.none, | ||
super( | ||
borderData: borderData ?? FlBorderData(show: false), | ||
touchData: pieTouchData ?? PieTouchData(), | ||
|
@@ -67,6 +73,9 @@ class PieChartData extends BaseChartData with EquatableMixin { | |
/// Whether to rotate the titles on each section of the chart | ||
final bool titleSunbeamLayout; | ||
|
||
/// Cap style of pie charts | ||
final CapStyle capStyle; | ||
|
||
/// We hold this value to determine weight of each [PieChartSectionData.value]. | ||
double get sumValue => sections | ||
.map((data) => data.value) | ||
|
@@ -83,6 +92,7 @@ class PieChartData extends BaseChartData with EquatableMixin { | |
PieTouchData? pieTouchData, | ||
FlBorderData? borderData, | ||
bool? titleSunbeamLayout, | ||
CapStyle? capStyle, | ||
}) => | ||
PieChartData( | ||
sections: sections ?? this.sections, | ||
|
@@ -93,6 +103,7 @@ class PieChartData extends BaseChartData with EquatableMixin { | |
pieTouchData: pieTouchData ?? this.pieTouchData, | ||
borderData: borderData ?? this.borderData, | ||
titleSunbeamLayout: titleSunbeamLayout ?? this.titleSunbeamLayout, | ||
capStyle: capStyle ?? this.capStyle, | ||
); | ||
|
||
/// Lerps a [BaseChartData] based on [t] value, check [Tween.lerp]. | ||
|
@@ -107,6 +118,7 @@ class PieChartData extends BaseChartData with EquatableMixin { | |
b.centerSpaceRadius, | ||
t, | ||
), | ||
capStyle: capStyle, | ||
pieTouchData: b.pieTouchData, | ||
sectionsSpace: lerpDouble(a.sectionsSpace, b.sectionsSpace, t), | ||
startDegreeOffset: | ||
|
@@ -130,6 +142,7 @@ class PieChartData extends BaseChartData with EquatableMixin { | |
startDegreeOffset, | ||
borderData, | ||
titleSunbeamLayout, | ||
capStyle, | ||
]; | ||
} | ||
|
||
|
@@ -401,3 +414,9 @@ class PieChartDataTween extends Tween<PieChartData> { | |
@override | ||
PieChartData lerp(double t) => begin!.lerp(begin!, end!, t); | ||
} | ||
|
||
enum CapStyle { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please write a documentation above it. And it seems it is specially for PieChart. So I think it makes sense to add |
||
none, | ||
startCapped, | ||
endCapped, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be
capStyle: b.capStyle,