Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export image #557

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Re-export image #557

merged 1 commit into from
Mar 15, 2024

Conversation

cospectrum
Copy link
Contributor

@cospectrum cospectrum commented Mar 15, 2024

The problem is described here.

This gives the user the ability to not depend on image, so the code will always compile.
Once this version of imageproc is published on crates.io, we can add use imageproc::image to the beginning of all examples.

@theotherphil
Copy link
Contributor

Ah, neat - I haven’t come across this before. Thanks.

I’ll publish a new crate version tomorrow.

@theotherphil theotherphil merged commit 03e4285 into image-rs:master Mar 15, 2024
14 checks passed
@cospectrum cospectrum deleted the reexport branch March 15, 2024 20:56
@cospectrum
Copy link
Contributor Author

cospectrum commented Mar 15, 2024

Ah, neat - I haven’t come across this before. Thanks.

I’ll publish a new crate version tomorrow.

Yes, I already see people trying to use image 0.25 with imageproc, but it doesn't compile.

About reexport. I'm wondering if we should add more image features. Because without "image/default", some examples will panic (decoding PNG or other formats) if imageproc::image is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants