-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition of "noise distribution" terms #191
Conversation
Could we mention "voxel-wise" somewhere? I think those distributions are defined on a voxel-by-voxel basis (otherwise we would have multivariate distributions?). |
Some comments...
There are some annoying subtitles here: For Gaussian data with GLM, it is very straightforward: This accounts for the vast majority of brain imaging, where the mass univariate model is used to fit the GLM at each voxel/element. However, as soon as you fall out of that, e.g. have binomial count data, you can no longer really disentangle noise from the data. That is, e.g., each binary counts in binomial data might be modelled with So!!!!! What I'm saying is that we need to be very clear what exactly we're doing. And I propose that we make a very loud and precise distinction that we are modelling the use of mass univariate linear model, fit at each voxel or other type of spatial element. "Univariate" excludes multivariate; "linear" excludes general_ised_ linear models. GIVEN that, yes, we can say these are univariate models (of course, by our "mass univariate" qualifier), not multivariate. |
+1 for +1 for being more specific and clearly state that we are modelling the use of mass univariate linear models. I think this could be an attribute of each activity ( |
Following on my comment on #192,
|
The following definitions are now implemented:
Do you think this is good to go? |
One tweak: for nonparametric change "defined" to "estimated". Just seems a little more accurate.
|
e18b54a
to
30d0128
Compare
Those definitions are now "pending final vetting". Would someone like to comment or +1? Latest version:
|
+1 for those - except that I would leave out: "Non-parametric distribution are usually estimated using permutation of the class labels or sign-flipping." since that is, while helpful, extraneous to the definition and then you would have to define what you mean by "permutation of class labels" and "sign-flipping" |
+1 for @khelm's mod... makes sense. Two tiny follow-up edits
(Added "s" to assumption).
(revised end of sentence, to stress that "only symmetry" is asummed). |
+1 for @nicholst follow-up edits |
+1 for those edits (now implemented). |
The tests passed. I think that this pull request is good to merge. |
Definition of "noise distribution" terms
This issue is a companion for #176 to define the terms created to model noise distributions, namely:
nidm:hasNoiseDistribution
nidm:NoiseDistribution
nidm:NonParametricDistribution
nidm:NonParametricSymmetricDistribution
(
nidm:BinomialDistribution
,nidm:GaussianDistribution
andnidm:PoissonDistribution
are already defined as synonyms of STATO terms following a comment by @nicholst at #176)Proposed definition:
I did not find the term "non-parametric distribution" in Bioportal (but "non-parametric test" is in NCIT). Once we settle on definitions, it might be worth suggesting them to STATO.
Please let me know what you think. @nicholst: would you like to comment on those definitions?