Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all CI pipelines are green before release #98

Closed
donyunardi opened this issue Jan 3, 2025 · 22 comments
Closed

Make sure all CI pipelines are green before release #98

donyunardi opened this issue Jan 3, 2025 · 22 comments
Assignees
@m7pr
Labels
core

Comments

@donyunardi
Copy link
Collaborator

donyunardi commented Jan 3, 2025 •
edited
Loading

Summary

Review all CI/CD pipeline (daily, Scheduled, etc) and make sure it's green before release.

Priority 1 - the frameworks

  • teal.code
  • teal.widgets
  • teal.data
  • teal.reporter
  • teal.slice
  • teal.transform
  • teal

Priority 2

  • tmg
  • tmc

Priority 3

  • osprey
  • teal.osprey
  • goshawk
  • teal.goshawk
  • hermes
  • teal.modules.hermes
  • helios
  • tel.modules.helios
@donyunardi donyunardi added the core label Jan 3, 2025
This was referenced Jan 3, 2025
Open
Open
@donyunardi
Copy link
Collaborator Author

donyunardi commented Jan 3, 2025 •
edited
Loading

teal.widgets ✅

Only Dependency Test - max failed in Scheduled pipeline

Assuming we're not adding formatters to teal.widgets dependency, this workflow will continue to fail until newest rtables/formatters are released.

teal.code ✅

revdepcheck failed because it's trying to run the teal.data 0.6.0 unit tests against teal.code main branch:
https://github.com/insightsengineering/teal.code/actions/runs/12532241545/job/34950765175

I believe this will go away once we release teal.data.

teal.data ✅

We have issue with min isolated test:

Only release is failing which is expected and will be resolved once we release teal.code:
https://github.com/insightsengineering/teal.data/actions/runs/12714861412

teal.slice

min_cohort is failing:
https://github.com/insightsengineering/teal.slice/actions/runs/12714930133/job/35446110038

teal.transform

teal.reporter

teal

@shajoezhu
Copy link
Collaborator

hi @donyunardi , we will release new formatters/rtables this month, perhaps we should meet and discuss

@averissimo averissimo self-assigned this Jan 8, 2025
@averissimo averissimo mentioned this issue Jan 9, 2025
Merged
@m7pr
Copy link

m7pr commented Jan 13, 2025

Just reviewed Priority 1 list and here is the status

Passing:

  • 🟢 teal.code failing in revdepcheck link but will pass once teal.data is released
  • 🟢 teal.logger - all fine link
  • 🟢 teal.widgets all fine link

Failing: - Error in deferred_run(env) : could not find function "deferred_run"

  • 🟥 teal.slice - failing in Dependency Tests link
  • 🟥 teal failing in all 4 Dependency Tests link
  • 🟥 teal.data failing in Dependency Test - release link
  • 🟥 teal.reporter failing in Dependency Tests - release and min_isolated link
  • 🟥 teal.transform failing in all 4 Dependency Tests link

@m7pr m7pr self-assigned this Jan 13, 2025
@m7pr
Copy link

m7pr commented Jan 13, 2025

Experimented with teal.data and I was able to overcome the issue

Error in deferred_run(env) : could not find function "deferred_run"

by loading withr at the beginning of the action's script
insightsengineering/r-verdepcheck-action#24

I will now restart all jobs that were failing

@m7pr
Copy link

m7pr commented Jan 14, 2025 •
edited
Loading

Current Priority 1 list status

Passing:

  • 🟢 teal.logger - all fine link
  • 🟢 teal.widgets all fine link

Failing but will pass once teal.code and teal.data are released:

  • 🟢 teal.data
  • 🟢 teal.transform
  • 🟢 teal.code

Failing:

  • 🟥 teal.slice - failing in min_isolated link can not install SummarizedExperiment
  • 🟥 teal failing in all 3 Dependency Tests link can't install rtables
  • 🟥 teal.reporter failing in min_isolated link 5 tests are failing

@m7pr
Copy link

m7pr commented Jan 14, 2025

Latest update

Current Priority 1 list status

Passing:

  • 🟢 teal.logger - all fine link
  • 🟢 teal.widgets all fine link
  • 🟢 teal.reporter failing only in release strategy

Failing but will pass once teal.code and teal.data are released:

  • 🟢 teal.data
  • 🟢 teal.transform
  • 🟢 teal.code

Failing:

  • 🟥 teal.slice - failing in min_isolated link can not install SummarizedExperiment
  • 🟥 teal failing in all 3 Dependency Tests link can't install rtables

@m7pr
Copy link

m7pr commented Jan 15, 2025

Latest update

Current Priority 1 list status

Passing:

  • 🟢 teal.logger all fine link
  • 🟢 teal.widgets all fine link
  • 🟢 teal.reporter failing only in release strategy
  • 🟢 teal.slice failing only in release strategy

Failing but will pass once teal.code and teal.data are released:

  • 🟢 teal.data
  • 🟢 teal.transform
  • 🟢 teal.code

Failing:

  • 🟥 teal failing in all 3 Dependency Tests link can't install rtables

@m7pr m7pr mentioned this issue Jan 15, 2025
Merged
m7pr added a commit to insightsengineering/teal.slice that referenced this issue Jan 15, 2025
@averissimo @m7pr
Fix scheduled inputs (#634)
b52deaa 
Part of insightsengineering/nestdevs-tasks#98

`extra-deps` was badly formed

---------

Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]>
Co-authored-by: m7pr <[email protected]>
@m7pr
Copy link

m7pr commented Jan 15, 2025

Latest update

Current Priority 1 list status

Passing:

  • 🟢 teal.logger all fine link
  • 🟢 teal.widgets all fine link
  • 🟢 teal.reporter failing only in release strategy
  • 🟢 teal.slice failing only in release strategy
  • 🟢 teal failing only in release strategy

Failing but will pass once teal.code and teal.data are released:

  • 🟢 teal.data
  • 🟢 teal.transform
  • 🟢 teal.code

@m7pr
Copy link

m7pr commented Jan 15, 2025

Will continue with tmg and tmc right now

m7pr added a commit to insightsengineering/teal that referenced this issue Jan 15, 2025
@m7pr @llrs-roche
Fix CI pipelines (#1445)
9b6ddd0 
Part of insightsengineering/nestdevs-tasks#98

---------

Co-authored-by: Lluís Revilla <[email protected]>
@m7pr m7pr mentioned this issue Jan 16, 2025
Merged
@m7pr
Copy link

m7pr commented Jan 16, 2025

Running builds for tmc and tmg today

@m7pr
Copy link

m7pr commented Jan 16, 2025

For both tmg and tmc I am struggling with inability to install teal.slice

@m7pr
Copy link

m7pr commented Jan 17, 2025

tmg passing
tmc still in progress

@m7pr
Copy link

m7pr commented Jan 20, 2025

tests are passing for tmc after recent release of tern https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12864924207

@m7pr
Copy link

m7pr commented Jan 20, 2025

Latest update

Current Priority 1 list status

Passing:

  • 🟢 teal.logger all fine link
  • 🟢 teal.widgets all fine link
  • 🟢 teal.reporter failing only in release strategy
  • 🟢 teal.slice failing only in release strategy
  • 🟢 teal failing only in release strategy

Failing but will pass once teal.code and teal.data are released:

  • 🟢 teal.data
  • 🟢 teal.transform
  • 🟢 teal.code

Current Priority 2 list status

  • 🟢 teal.modules.general failing only in release strategy
  • 🟢 teal.modules.clinical failing only in release strategy

Moving to Priority 3 list

This was referenced Jan 21, 2025
Merged
Merged
@m7pr
Copy link

m7pr commented Jan 21, 2025

Update on Priority list 3

  • 🟢 osprey - green
  • 🟢 teal.osprey - fixed
  • 🔴 goshawk - failing in min_isolated and donttest
  • ♾ teal.goshawk - fixed for 2 out of 3 strategies and work in progress

m7pr added a commit to insightsengineering/teal.osprey that referenced this issue Jan 21, 2025
@m7pr @github-actions
update packages versions for scheduled build (#292)
aa16fa9 
Part of insightsengineering/nestdevs-tasks#98

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
m7pr added a commit to insightsengineering/teal.modules.clinical that referenced this issue Jan 21, 2025
@m7pr @shajoezhu
update packages for the scheduled build (#1314)
1d12d81 
Running build
https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12806427331
Part of insightsengineering/nestdevs-tasks#98

---------

Co-authored-by: Joe Zhu <[email protected]>
@gogonzo
Copy link

gogonzo commented Jan 21, 2025

@m7pr why MultiAssayExperiment and SummarizedExperiment are bumped to the latest bioc version? Theoretically they should work with the old versions too.

@m7pr
Copy link

m7pr commented Jan 21, 2025 •
edited
Loading

We discussed this here insightsengineering/teal#1445 (comment)

@m7pr
Copy link

m7pr commented Jan 22, 2025 •
edited
Loading

Latest update

Current Priority 1 list status

Passing:

  • 🟢 teal.logger all fine link
  • 🟢 teal.widgets all fine link
  • 🟢 teal.reporter failing only in release strategy
  • 🟢 teal.slice failing only in release strategy
  • 🟢 teal failing only in release strategy

Failing but will pass once teal.code and teal.data are released:

  • 🟢 teal.data
  • 🟢 teal.transform
  • 🟢 teal.code

Current Priority 2 list status

  • 🟢 teal.modules.general failing only in release strategy
  • 🟢 teal.modules.clinical failing only in release strategy

Current Priority 3 list status

  • 🟢 osprey - green
  • 🟢 teal.osprey - fixed
  • 🟢 goshawk - failing only in release strategy
  • ♾ teal.goshawk - fixed for 2 out of 3 strategies and work in progress
  • ♾ hermes
  • ♾ helios
  • ♾ teal.modules.hermes
  • 🕶 teal.modules.helios - BUILDS ARE DISABLED FOR THIS REPO

@m7pr
Copy link

m7pr commented Jan 22, 2025

Hey @gogonzo and @donyunardi , a comment about MultiAssayExperiment and SummarizedExperiment

insightsengineering/teal.slice#637 (comment)

m7pr added a commit to insightsengineering/teal.goshawk that referenced this issue Jan 24, 2025
@m7pr @github-actions @llrs-roche
update packages versions for scheduled build (#330)
39204c7 
Part of insightsengineering/nestdevs-tasks#98
Build
https://github.com/insightsengineering/teal.goshawk/actions/runs/12882792248

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Lluís Revilla <[email protected]>
@m7pr
Copy link

m7pr commented Jan 24, 2025

Latest update

Current Priority 1 list status

Passing:

  • 🟢 teal.logger
  • 🟢 teal.widgets
  • 🟢 teal.reporter
  • 🟢 teal.slice
  • 🟢 teal

Failing but will pass once teal.code and teal.data are released:

  • 🟢 teal.data
  • 🟢 teal.transform
  • 🟢 teal.code

Current Priority 2 list status

  • 🟢 teal.modules.general
  • 🟢 teal.modules.clinical

Current Priority 3 list status

  • 🟢 osprey
  • 🟢 teal.osprey
  • 🟢 goshawk
  • 🟢 teal.goshawk
  • 🟢 hermes
  • ♾ helios
  • ♾ teal.modules.hermes
  • 🕶 teal.modules.helios - BUILDS ARE DISABLED FOR THIS REPO

@m7pr
Copy link

m7pr commented Jan 28, 2025

Hey, all packages are fixed. Will just review them once more, as some packages landed on CRAN

@m7pr m7pr mentioned this issue Jan 29, 2025
Open
@m7pr
Copy link

m7pr commented Jan 29, 2025

All pipelines are green, closing this card and starting a similar card to review pipelines after the releases
#101

@m7pr m7pr closed this as completed Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m7pr m7pr

Labels
core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@averissimo @shajoezhu @gogonzo @donyunardi @m7pr