-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/#538/seed example addition error #542
base: main
Are you sure you want to change the base?
Bug/#538/seed example addition error #542
Conversation
…utton within button error. Skill form. Signed-off-by: Ash Evans <[email protected]>
…utton within button error. Knowledge Native form. Signed-off-by: Ash Evans <[email protected]>
@aevo98765 Thanks for the PR and welcome back !! Few review comments:
|
Signed-off-by: Ash Evans <[email protected]>
…elete button takes. Also only rendering the delete button on accordion collapse Signed-off-by: Ash Evans <[email protected]>
Signed-off-by: Ash Evans <[email protected]>
I have changed this so: 1) The delete button is only displayed when the accordion is closed. 2) Changed the layout proportions so that the delete button takes up less room. |
Yeh it looks like when the project is built and started then this error does not occur. Happy to just have this error existing if the end user is never going to encounter it. |
I think we can defer it till we hit it in prod. There are few new design changes are proposed by UX team as well, and that might help resolve this issue as well. |
No description provided.