Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/#538/seed example addition error #542

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bug/#538/seed example addition error #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f86b216
moving the delete button out of the Accordion Toggle to resolve the b…
aevo98765 Feb 3, 2025
073c119
moving the delete button out of the Accordion Toggle to resolve the b…
aevo98765 Feb 3, 2025
3589cdf
merge main
aevo98765 Feb 4, 2025
9c19151
Changing the proportions of the layout to reduce the space that the d…
aevo98765 Feb 4, 2025
bb9a9bd
moving the seed example delete button in github develepment mode
aevo98765 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 31 additions & 25 deletions src/components/Contribute/Knowledge/Github/KnowledgeSeedExample/KnowledgeSeedExample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,31 +61,37 @@ const KnowledgeSeedExample: React.FC<Props> = ({

<Accordion asDefinitionList={false}>
{seedExamples.map((seedExample: KnowledgeSeedExample, seedExampleIndex: number) => (
<AccordionItem key={seedExampleIndex} isExpanded={seedExample.isExpanded}>
<AccordionToggle onClick={() => toggleSeedExampleExpansion(seedExampleIndex)} id={`seed-example-toggle-${seedExampleIndex}`}>
<span style={{ display: 'flex', alignItems: 'normal', justifyContent: 'space-between', width: '100%' }}>
Seed Example {seedExampleIndex + 1} {seedExample.immutable && '*'}
{!seedExample.immutable && (
<Button icon={<TrashIcon />} variant="plain" aria-label="Remove" onClick={() => deleteSeedExample(seedExampleIndex)} />
)}
</span>
</AccordionToggle>
<AccordionContent id={`seed-example-content-${seedExampleIndex}`}>
<KnowledgeQuestionAnswerPairs
seedExample={seedExample}
seedExampleIndex={seedExampleIndex}
handleContextInputChange={handleContextInputChange}
handleContextBlur={handleContextBlur}
handleQuestionInputChange={handleQuestionInputChange}
handleQuestionBlur={handleQuestionBlur}
handleAnswerInputChange={handleAnswerInputChange}
handleAnswerBlur={handleAnswerBlur}
addDocumentInfo={addDocumentInfo}
repositoryUrl={repositoryUrl}
commitSha={commitSha}
/>
</AccordionContent>
</AccordionItem>
<div key={seedExampleIndex} style={{ display: 'flex', alignItems: 'center', width: '100%' }}>
<div style={{ flex: 9.5 }}>
<AccordionItem key={seedExampleIndex} isExpanded={seedExample.isExpanded}>
<AccordionToggle onClick={() => toggleSeedExampleExpansion(seedExampleIndex)} id={`seed-example-toggle-${seedExampleIndex}`}>
<span style={{ display: 'flex', alignItems: 'normal', justifyContent: 'space-between', width: '100%' }}>
Seed Example {seedExampleIndex + 1} {seedExample.immutable && '*'}
</span>
</AccordionToggle>
<AccordionContent id={`seed-example-content-${seedExampleIndex}`}>
<KnowledgeQuestionAnswerPairs
seedExample={seedExample}
seedExampleIndex={seedExampleIndex}
handleContextInputChange={handleContextInputChange}
handleContextBlur={handleContextBlur}
handleQuestionInputChange={handleQuestionInputChange}
handleQuestionBlur={handleQuestionBlur}
handleAnswerInputChange={handleAnswerInputChange}
handleAnswerBlur={handleAnswerBlur}
addDocumentInfo={addDocumentInfo}
repositoryUrl={repositoryUrl}
commitSha={commitSha}
/>
</AccordionContent>
</AccordionItem>
</div>
<div style={{ flex: 0.5, display: 'flex', justifyContent: 'center', alignItems: 'center' }}>
{!seedExample.immutable && !seedExample.isExpanded && (
<Button icon={<TrashIcon />} variant="plain" aria-label="Remove" onClick={() => deleteSeedExample(seedExampleIndex)} />
)}
</div>
</div>
))}
</Accordion>
<div style={{ display: 'flex', justifyContent: 'flex-start' }}>
Expand Down
56 changes: 31 additions & 25 deletions ...nts/Contribute/Knowledge/Native/KnowledgeSeedExampleNative/KnowledgeSeedExampleNative.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,31 +61,37 @@ const KnowledgeSeedExampleNative: React.FC<Props> = ({

<Accordion asDefinitionList={false}>
{seedExamples.map((seedExample: KnowledgeSeedExample, seedExampleIndex: number) => (
<AccordionItem key={seedExampleIndex} isExpanded={seedExample.isExpanded}>
<AccordionToggle onClick={() => toggleSeedExampleExpansion(seedExampleIndex)} id={`seed-example-toggle-${seedExampleIndex}`}>
<span style={{ display: 'flex', alignItems: 'normal', justifyContent: 'space-between', width: '100%' }}>
Seed Example {seedExampleIndex + 1} {seedExample.immutable && '*'}
{!seedExample.immutable && (
<Button icon={<TrashIcon />} variant="plain" aria-label="Remove" onClick={() => deleteSeedExample(seedExampleIndex)} />
)}
</span>
</AccordionToggle>
<AccordionContent id={`seed-example-content-${seedExampleIndex}`}>
<KnowledgeQuestionAnswerPairsNative
seedExample={seedExample}
seedExampleIndex={seedExampleIndex}
handleContextInputChange={handleContextInputChange}
handleContextBlur={handleContextBlur}
handleQuestionInputChange={handleQuestionInputChange}
handleQuestionBlur={handleQuestionBlur}
handleAnswerInputChange={handleAnswerInputChange}
handleAnswerBlur={handleAnswerBlur}
addDocumentInfo={addDocumentInfo}
repositoryUrl={repositoryUrl}
commitSha={commitSha}
/>
</AccordionContent>
</AccordionItem>
<div key={seedExampleIndex} style={{ display: 'flex', alignItems: 'center', width: '100%' }}>
<div style={{ flex: 9.5 }}>
<AccordionItem key={seedExampleIndex} isExpanded={seedExample.isExpanded}>
<AccordionToggle onClick={() => toggleSeedExampleExpansion(seedExampleIndex)} id={`seed-example-toggle-${seedExampleIndex}`}>
<span style={{ display: 'flex', alignItems: 'normal', justifyContent: 'space-between', width: '100%' }}>
Seed Example {seedExampleIndex + 1} {seedExample.immutable && '*'}
</span>
</AccordionToggle>
<AccordionContent id={`seed-example-content-${seedExampleIndex}`}>
<KnowledgeQuestionAnswerPairsNative
seedExample={seedExample}
seedExampleIndex={seedExampleIndex}
handleContextInputChange={handleContextInputChange}
handleContextBlur={handleContextBlur}
handleQuestionInputChange={handleQuestionInputChange}
handleQuestionBlur={handleQuestionBlur}
handleAnswerInputChange={handleAnswerInputChange}
handleAnswerBlur={handleAnswerBlur}
addDocumentInfo={addDocumentInfo}
repositoryUrl={repositoryUrl}
commitSha={commitSha}
/>
</AccordionContent>
</AccordionItem>
</div>
<div style={{ flex: 0.5, display: 'flex', justifyContent: 'center', alignItems: 'center' }}>
{!seedExample.immutable && !seedExample.isExpanded && (
<Button icon={<TrashIcon />} variant="plain" aria-label="Remove" onClick={() => deleteSeedExample(seedExampleIndex)} />
)}
</div>
</div>
))}
</Accordion>
<div style={{ display: 'flex', justifyContent: 'flex-start' }}>
Expand Down
144 changes: 75 additions & 69 deletions src/components/Contribute/Skill/SkillsSeedExample/SkillsSeedExample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,75 +65,81 @@ const SkillsSeedExample: React.FC<Props> = ({
/>
<Accordion asDefinitionList={false}>
{seedExamples.map((seedExample: SkillSeedExample, seedExampleIndex: number) => (
<AccordionItem key={seedExampleIndex} isExpanded={seedExample.isExpanded}>
<AccordionToggle onClick={() => toggleSeedExampleExpansion(seedExampleIndex)} id={`seed-example-toggle-${seedExampleIndex}`}>
<span style={{ display: 'flex', alignItems: 'normal', justifyContent: 'space-between', width: '100%' }}>
Seed Example {seedExampleIndex + 1} {seedExample.immutable && '*'}
{!seedExample.immutable && (
<Button icon={<TrashIcon />} variant="plain" aria-label="Remove" onClick={() => deleteSeedExample(seedExampleIndex)} />
)}
</span>
</AccordionToggle>
<AccordionContent id={`seed-example-content-${seedExampleIndex}`}>
<FormGroup isRequired key={seedExampleIndex + '-question'} label="Question">
<TextArea
key={seedExampleIndex * 10 + 2}
isRequired
type="text"
aria-label={`Question ${seedExampleIndex + 1}`}
placeholder={`Enter question ${seedExampleIndex + 1}`}
value={seedExample.question}
validated={seedExample.isQuestionValid}
onChange={(_event, questionValue) => handleQuestionInputChange(seedExampleIndex, questionValue)}
onBlur={() => handleQuestionBlur(seedExampleIndex)}
/>
{seedExample.isQuestionValid === ValidatedOptions.error && (
<FormHelperText key={seedExampleIndex * 100 + 2}>
<HelperText>
<HelperTextItem icon={<ExclamationCircleIcon />} variant={seedExample.isQuestionValid}>
{seedExample.questionValidationError || 'Required field '}
</HelperTextItem>
</HelperText>
</FormHelperText>
)}
</FormGroup>
<FormGroup key={seedExampleIndex + '-context'} label="Context">
<TextArea
key={seedExampleIndex * 10 + 1}
isRequired
type="text"
aria-label={`Context ${seedExampleIndex + 1}`}
placeholder="Enter the context for the question and answer pair. (optional)"
value={seedExample.context}
validated={seedExample.isContextValid}
onChange={(_event, contextValue: string) => handleContextInputChange(seedExampleIndex, contextValue)}
onBlur={() => handleContextBlur(seedExampleIndex)}
/>
</FormGroup>
<FormGroup isRequired key={seedExampleIndex + '-answer'} label="Answer">
<TextArea
key={seedExampleIndex * 10 + 3}
isRequired
type="text"
aria-label={`Answer ${seedExampleIndex + 1}`}
placeholder={`Enter answer ${seedExampleIndex + 1}`}
value={seedExample.answer}
validated={seedExample.isAnswerValid}
onChange={(_event, answerValue) => handleAnswerInputChange(seedExampleIndex, answerValue)}
onBlur={() => handleAnswerBlur(seedExampleIndex)}
/>
{seedExample.isAnswerValid === ValidatedOptions.error && (
<FormHelperText key={seedExampleIndex * 100 + 4}>
<HelperText>
<HelperTextItem icon={<ExclamationCircleIcon />} variant={seedExample.isAnswerValid}>
{seedExample.answerValidationError || 'Required field'}
</HelperTextItem>
</HelperText>
</FormHelperText>
)}
</FormGroup>
</AccordionContent>
</AccordionItem>
<div key={seedExampleIndex} style={{ display: 'flex', alignItems: 'center', width: '100%' }}>
<div style={{ flex: 9.5 }}>
<AccordionItem key={seedExampleIndex} isExpanded={seedExample.isExpanded}>
<AccordionToggle onClick={() => toggleSeedExampleExpansion(seedExampleIndex)} id={`seed-example-toggle-${seedExampleIndex}`}>
<span style={{ display: 'flex', alignItems: 'normal', justifyContent: 'space-between', width: '100%' }}>
Seed Example {seedExampleIndex + 1} {seedExample.immutable && '*'}
</span>
</AccordionToggle>
<AccordionContent id={`seed-example-content-${seedExampleIndex}`}>
<FormGroup isRequired key={seedExampleIndex + '-question'} label="Question">
<TextArea
key={seedExampleIndex * 10 + 2}
isRequired
type="text"
aria-label={`Question ${seedExampleIndex + 1}`}
placeholder={`Enter question ${seedExampleIndex + 1}`}
value={seedExample.question}
validated={seedExample.isQuestionValid}
onChange={(_event, questionValue) => handleQuestionInputChange(seedExampleIndex, questionValue)}
onBlur={() => handleQuestionBlur(seedExampleIndex)}
/>
{seedExample.isQuestionValid === ValidatedOptions.error && (
<FormHelperText key={seedExampleIndex * 100 + 2}>
<HelperText>
<HelperTextItem icon={<ExclamationCircleIcon />} variant={seedExample.isQuestionValid}>
{seedExample.questionValidationError || 'Required field '}
</HelperTextItem>
</HelperText>
</FormHelperText>
)}
</FormGroup>
<FormGroup key={seedExampleIndex + '-context'} label="Context">
<TextArea
key={seedExampleIndex * 10 + 1}
isRequired
type="text"
aria-label={`Context ${seedExampleIndex + 1}`}
placeholder="Enter the context for the question and answer pair. (optional)"
value={seedExample.context}
validated={seedExample.isContextValid}
onChange={(_event, contextValue: string) => handleContextInputChange(seedExampleIndex, contextValue)}
onBlur={() => handleContextBlur(seedExampleIndex)}
/>
</FormGroup>
<FormGroup isRequired key={seedExampleIndex + '-answer'} label="Answer">
<TextArea
key={seedExampleIndex * 10 + 3}
isRequired
type="text"
aria-label={`Answer ${seedExampleIndex + 1}`}
placeholder={`Enter answer ${seedExampleIndex + 1}`}
value={seedExample.answer}
validated={seedExample.isAnswerValid}
onChange={(_event, answerValue) => handleAnswerInputChange(seedExampleIndex, answerValue)}
onBlur={() => handleAnswerBlur(seedExampleIndex)}
/>
{seedExample.isAnswerValid === ValidatedOptions.error && (
<FormHelperText key={seedExampleIndex * 100 + 4}>
<HelperText>
<HelperTextItem icon={<ExclamationCircleIcon />} variant={seedExample.isAnswerValid}>
{seedExample.answerValidationError || 'Required field'}
</HelperTextItem>
</HelperText>
</FormHelperText>
)}
</FormGroup>
</AccordionContent>
</AccordionItem>
</div>
<div style={{ flex: 0.5, display: 'flex', justifyContent: 'center', alignItems: 'center' }}>
{!seedExample.immutable && !seedExample.isExpanded && (
<Button icon={<TrashIcon />} variant="plain" aria-label="Remove" onClick={() => deleteSeedExample(seedExampleIndex)} />
)}
</div>
</div>
))}
</Accordion>
<div style={{ display: 'flex', justifyContent: 'flex-start' }}>
Expand Down