Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Go1.23.3 #4532

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade to Go1.23.3 #4532

wants to merge 3 commits into from
+8 −8

Conversation

envestcc
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@envestcc envestcc requested review from CoderZhi, dustinxie, Liuhaai and a team as code owners December 24, 2024 17:27
@envestcc envestcc mentioned this pull request Dec 24, 2024
Open
10 tasks
CoderZhi
CoderZhi reviewed Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@CoderZhi CoderZhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do a full sync to verify the change

action/receipt.go Outdated
Comment on lines 207 to 209
staleTopic = topic
if log.NotFixTopicCopyBug {
l.Topics = append(l.Topics, topic[:])
l.Topics = append(l.Topics, staleTopic[:])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not easy to read. what about

    if log.NotFixTopicCopyBug {
        staleTopic := log.Topics[-1]
        for _ := range log.Topics {
             l.Topics = append(l.Topics, staleTopic)
        }
    } else {
       for _, topic := range log.Topics {
            ...
       }
    }

be ware of the case len(l.Topics)==0

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@envestcc
Copy link
Member Author

envestcc commented Jan 7, 2025 •
edited
Loading

let's do a full sync to verify the change

indeed, fullsync is necessary. There are quite a few loop codes that will lead to different compiler behaviors according to the official tool.

> go build -gcflags=all=-d=loopvar=2 -o ./bin/server -v ./server > ignore

# runtime
../../sdk/go1.23.3/src/runtime/mgcmark.go:895:6: loop variable d now per-iteration, stack-allocated
../../sdk/go1.23.3/src/runtime/proc.go:2179:7: loop variable freem now per-iteration, stack-allocated
../../sdk/go1.23.3/src/runtime/proc.go:3663:7: loop variable enum now per-iteration, stack-allocated
../../sdk/go1.23.3/src/runtime/traceback.go:628:7: loop variable iu now per-iteration, stack-allocated
../../sdk/go1.23.3/src/runtime/traceback.go:970:7: loop variable iu now per-iteration, stack-allocated
# vendor/golang.org/x/net/dns/dnsmessage
../../sdk/go1.23.3/src/vendor/golang.org/x/net/dns/dnsmessage/message.go:1176:10: loop variable q now per-iteration, stack-allocated
../../sdk/go1.23.3/src/vendor/golang.org/x/net/dns/dnsmessage/message.go:1183:10: loop variable a now per-iteration, stack-allocated
../../sdk/go1.23.3/src/vendor/golang.org/x/net/dns/dnsmessage/message.go:1190:10: loop variable a now per-iteration, stack-allocated
../../sdk/go1.23.3/src/vendor/golang.org/x/net/dns/dnsmessage/message.go:1197:10: loop variable a now per-iteration, stack-allocated
../../sdk/go1.23.3/src/vendor/golang.org/x/net/dns/dnsmessage/message.go:2651:9: loop variable o now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/rlp
../go/pkg/mod/github.com/iotexproject/[email protected]/rlp/encbuffer.go:68:9: loop variable head now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/rlp/encbuffer.go:84:9: loop variable head now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/accounts/abi
../go/pkg/mod/github.com/iotexproject/[email protected]/accounts/abi/abi.go:229:9: loop variable errABI now per-iteration, heap-allocated
# net
../../sdk/go1.23.3/src/net/dnsclient_unix.go:583:9: loop variable ip now per-iteration, stack-allocated
../../sdk/go1.23.3/src/net/cgo_unix.go:92:9: loop variable addr now per-iteration, stack-allocated
../../sdk/go1.23.3/src/net/unixsock_readmsg_cloexec.go:19:9: loop variable scm now per-iteration, stack-allocated
../../sdk/go1.23.3/src/net/interface.go:158:9: loop variable ifi now per-iteration, heap-allocated (loop inlined into ../../sdk/go1.23.3/src/net/interface.go:150)
# gopkg.in/yaml.v2
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:81:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1265:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1322:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1378:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1435:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1605:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1645:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:81:6: loop variable i now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1227)
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:81:6: loop variable i now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1237)
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:81:6: loop variable i now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1251)
# crypto/x509
../../sdk/go1.23.3/src/crypto/x509/verify.go:861:9: loop variable ext now per-iteration, heap-allocated
../../sdk/go1.23.3/src/crypto/x509/verify.go:876:10: loop variable ext now per-iteration, heap-allocated
../../sdk/go1.23.3/src/crypto/x509/x509.go:1230:11: loop variable name now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/x509/x509.go:1242:11: loop variable ipNet now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/x509/x509.go:1250:11: loop variable email now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/x509/x509.go:1262:11: loop variable uriDomain now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/x509/x509.go:1396:11: loop variable v now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/x509/x509.go:1408:11: loop variable v now per-iteration, stack-allocated
# github.com/cockroachdb/logtags
../go/pkg/mod/github.com/cockroachdb/[email protected]/buffer.go:47:9: loop variable t now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/buffer.go:76:9: loop variable t now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/buffer.go:165:9: loop variable t now per-iteration, stack-allocated
# crypto/tls
../../sdk/go1.23.3/src/crypto/tls/common.go:1226:9: loop variable cert now per-iteration, heap-allocated
../../sdk/go1.23.3/src/crypto/tls/ticket.go:122:10: loop variable extra now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/ticket.go:144:10: loop variable chain now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/ticket.go:151:12: loop variable cert now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/ticket.go:375:9: loop variable key now per-iteration, heap-allocated
../../sdk/go1.23.3/src/crypto/tls/handshake_messages.go:240:13: loop variable proto now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/handshake_messages.go:285:13: loop variable ks now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/handshake_messages.go:323:12: loop variable psk now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/handshake_messages.go:331:12: loop variable binder now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/handshake_messages.go:775:12: loop variable sct now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/handshake_messages.go:1276:14: loop variable ca now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/handshake_messages.go:1463:7: loop variable i now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/handshake_messages.go:1463:10: loop variable cert now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/handshake_messages.go:1485:15: loop variable sct now per-iteration, stack-allocated
../../sdk/go1.23.3/src/crypto/tls/handshake_client.go:1234:9: loop variable chain now per-iteration, heap-allocated
../../sdk/go1.23.3/src/crypto/tls/handshake_server_tls13.go:187:9: loop variable preferredGroup now per-iteration, stack-allocated
# github.com/gogo/protobuf/proto
../go/pkg/mod/github.com/gogo/[email protected]/proto/extensions_gogo.go:163:9: loop variable e now per-iteration, stack-allocated
../go/pkg/mod/github.com/gogo/[email protected]/proto/extensions_gogo.go:179:9: loop variable e now per-iteration, stack-allocated
# golang.org/x/text/language
../go/pkg/mod/golang.org/x/[email protected]/language/coverage.go:126:10: loop variable t now per-iteration, stack-allocated
../go/pkg/mod/golang.org/x/[email protected]/language/match.go:382:9: loop variable tag now per-iteration, stack-allocated
../go/pkg/mod/golang.org/x/[email protected]/language/match.go:391:9: loop variable tag now per-iteration, stack-allocated
../go/pkg/mod/golang.org/x/[email protected]/language/match.go:455:9: loop variable ww now per-iteration, stack-allocated
../go/pkg/mod/golang.org/x/[email protected]/language/match.go:495:10: loop variable t now per-iteration, stack-allocated
# runtime/pprof
../../sdk/go1.23.3/src/runtime/pprof/proto.go:363:6: loop variable e now per-iteration, stack-allocated
../../sdk/go1.23.3/src/runtime/pprof/proto.go:612:9: loop variable frame now per-iteration, stack-allocated
../../sdk/go1.23.3/src/runtime/pprof/protomem.go:30:9: loop variable r now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/core/types
../go/pkg/mod/github.com/iotexproject/[email protected]/core/types/bloom9.go:110:11: loop variable b now per-iteration, heap-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/types/bloom9.go:124:10: loop variable b now per-iteration, heap-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/types/gen_log_rlp.go:13:9: loop variable _tmp2 now per-iteration, stack-allocated
# github.com/cockroachdb/errors/errorspb
../go/pkg/mod/github.com/cockroachdb/[email protected]/errorspb/markers.pb.go:152:10: loop variable e now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/errorspb/tags.pb.go:213:10: loop variable e now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/accounts
../go/pkg/mod/github.com/iotexproject/[email protected]/accounts/manager.go:252:9: loop variable wallet now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/accounts/manager.go:266:9: loop variable wallet now per-iteration, stack-allocated
# google.golang.org/protobuf/internal/impl
../go/pkg/mod/google.golang.org/[email protected]/internal/impl/encode.go:170:9: loop variable x now per-iteration, stack-allocated
../go/pkg/mod/google.golang.org/[email protected]/internal/impl/encode.go:199:10: loop variable x now per-iteration, stack-allocated
../go/pkg/mod/google.golang.org/[email protected]/internal/impl/merge.go:60:12: loop variable sx now per-iteration, stack-allocated
../go/pkg/mod/google.golang.org/[email protected]/internal/impl/message_reflect.go:238:10: loop variable x now per-iteration, stack-allocated
../go/pkg/mod/google.golang.org/[email protected]/internal/impl/checkinit.go:69:9: loop variable x now per-iteration, stack-allocated
# golang.org/x/net/trace
../go/pkg/mod/golang.org/x/[email protected]/trace/trace.go:505:6: loop variable tr now per-iteration, stack-allocated
# github.com/cockroachdb/errors/contexttags
../go/pkg/mod/github.com/cockroachdb/[email protected]/contexttags/with_context.go:81:9: loop variable t now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/contexttags/contexttags.go:70:9: loop variable t now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/contexttags/contexttags.go:83:9: loop variable t now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/contexttags/contexttags.go:99:9: loop variable t now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/contexttags/contexttags.go:70:9: loop variable t now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/github.com/cockroachdb/[email protected]/contexttags/contexttags.go:60)
# github.com/iotexproject/iotex-core/v2/action
action/receipt.go:203:9: loop variable topic now per-iteration, heap-allocated
action/receipt.go:203:9: loop variable topic now per-iteration, heap-allocated (loop inlined into action/receipt.go:71)
action/receipt.go:203:9: loop variable topic now per-iteration, heap-allocated (loop inlined into action/receipt.go:237)
# encoding/xml
../../sdk/go1.23.3/src/encoding/xml/typeinfo.go:81:13: loop variable finfo now per-iteration, stack-allocated
# github.com/prometheus/client_golang/prometheus
../go/pkg/mod/github.com/prometheus/[email protected]/prometheus/go_collector_latest.go:198:9: loop variable d now per-iteration, stack-allocated
../go/pkg/mod/github.com/prometheus/[email protected]/prometheus/metric.go:181:10: loop variable e now per-iteration, stack-allocated
../go/pkg/mod/github.com/prometheus/[email protected]/prometheus/expvar_collector.go:44:12: loop variable desc now per-iteration, stack-allocated
# github.com/cockroachdb/pebble/internal/manifest
../go/pkg/mod/github.com/cockroachdb/[email protected]/internal/manifest/l0_sublevels.go:1043:6: loop variable level now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/internal/manifest/version.go:907:9: loop variable iter now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/internal/manifest/version.go:1225:9: loop variable lm now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/internal/manifest/version.go:1228:9: loop variable lm now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/internal/manifest/version.go:1364:13: loop variable lm now per-iteration, stack-allocated
# google.golang.org/grpc
../go/pkg/mod/google.golang.org/[email protected]/clientconn.go:1312:9: loop variable addr now per-iteration, heap-allocated
# go.opentelemetry.io/otel/sdk/trace
../go/pkg/mod/go.opentelemetry.io/otel/[email protected]/trace/provider.go:278:9: loop variable sps now per-iteration, stack-allocated
# go.opentelemetry.io/otel/exporters/jaeger
../go/pkg/mod/go.opentelemetry.io/otel/exporters/[email protected]/jaeger.go:340:7: loop variable iter now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/p2p/netutil
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:93:9: loop variable net now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:130:9: loop variable net now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:130:9: loop variable net now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:144)
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:130:9: loop variable net now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:146)
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:130:9: loop variable net now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:156)
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:130:9: loop variable net now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:158)
# github.com/ethereum/go-ethereum/core/bloombits
../go/pkg/mod/github.com/iotexproject/[email protected]/core/bloombits/matcher.go:486:12: loop variable section now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/eth/tracers/logger
../go/pkg/mod/github.com/iotexproject/[email protected]/eth/tracers/logger/logger.go:371:10: loop variable elem now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/eth/tracers/logger/logger.go:431:13: loop variable trace now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/eth/tracers/logger/logger.go:443:11: loop variable stackValue now per-iteration, stack-allocated
# github.com/cockroachdb/pebble/sstable
../go/pkg/mod/github.com/cockroachdb/[email protected]/sstable/reader.go:651:11: loop variable value now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/sstable/reader.go:826:12: loop variable value now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/sstable/reader.go:840:12: loop variable value now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/sstable/reader.go:856:13: loop variable value now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/sstable/layout.go:189:13: loop variable value now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/sstable/layout.go:241:13: loop variable value now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/sstable/suffix_rewriter.go:224:12: loop variable val now per-iteration, stack-allocated
# github.com/huin/goupnp
../go/pkg/mod/github.com/huin/[email protected]/network.go:50:9: loop variable iface now per-iteration, stack-allocated
# github.com/google/pprof/profile
../go/pkg/mod/github.com/google/[email protected]/profile/encode.go:323:11: loop variable l now per-iteration, stack-allocated
../go/pkg/mod/github.com/google/[email protected]/profile/encode.go:379:9: loop variable i now per-iteration, stack-allocated
# github.com/dlclark/regexp2
../go/pkg/mod/github.com/dlclark/[email protected]/match.go:326:10: loop variable c now per-iteration, stack-allocated
# github.com/gballet/go-verkle
../go/pkg/mod/github.com/gballet/[email protected]/proof_ipa.go:313:9: loop variable poaStem now per-iteration, stack-allocated
../go/pkg/mod/github.com/gballet/[email protected]/proof_ipa.go:321:9: loop variable commitmentBytes now per-iteration, stack-allocated
../go/pkg/mod/github.com/gballet/[email protected]/proof_ipa.go:334:9: loop variable b now per-iteration, stack-allocated
../go/pkg/mod/github.com/gballet/[email protected]/proof_ipa.go:340:9: loop variable b now per-iteration, stack-allocated
../go/pkg/mod/github.com/gballet/[email protected]/proof_ipa.go:347:9: loop variable stemdiff now per-iteration, stack-allocated
../go/pkg/mod/github.com/gballet/[email protected]/proof_ipa.go:489:9: loop variable stemstatediff now per-iteration, stack-allocated
../go/pkg/mod/github.com/gballet/[email protected]/proof_json.go:137:9: loop variable s now per-iteration, stack-allocated
../go/pkg/mod/github.com/gballet/[email protected]/proof_json.go:140:9: loop variable c now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/p2p/nat
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/nat/natpmp.go:112:9: loop variable iface now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/nat/natupnp.go:137:9: loop variable iface now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/nat/natupnp.go:218:6: loop variable i now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/signer/core/apitypes
../go/pkg/mod/github.com/iotexproject/[email protected]/signer/core/apitypes/types.go:629:9: loop variable field now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/signer/core/apitypes/types.go:713:10: loop variable typeObj now per-iteration, stack-allocated
# github.com/grpc-ecosystem/go-grpc-prometheus
../go/pkg/mod/github.com/grpc-ecosystem/[email protected]/server_metrics.go:134:10: loop variable mInfo now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/p2p/discover
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:130:9: loop variable netutil.net now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/discover/table.go:212)
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:130:9: loop variable netutil.net now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/discover/v4_udp.go:585)
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:130:9: loop variable netutil.net now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/discover/v5_udp.go:432)
# github.com/ethereum/go-ethereum/p2p
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:130:9: loop variable netutil.net now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/dial.go:390)
../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/netutil/net.go:130:9: loop variable netutil.net now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/github.com/iotexproject/[email protected]/p2p/server.go:916)
# github.com/go-redis/redis/v8
../go/pkg/mod/github.com/go-redis/redis/[email protected]/cluster.go:1104:6: loop variable attempt now per-iteration, heap-allocated
../go/pkg/mod/github.com/go-redis/redis/[email protected]/cluster.go:1297:7: loop variable attempt now per-iteration, heap-allocated
# github.com/cockroachdb/pebble
../go/pkg/mod/github.com/cockroachdb/[email protected]/batch.go:444:6: loop variable r now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/batch.go:498:7: loop variable iter now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/batch.go:1206:11: loop variable val now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/batch.go:1281:10: loop variable val now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/batch.go:1744:7: loop variable iter now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/db.go:2217:13: loop variable files now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/mem_table.go:213:6: loop variable r now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/mem_table.go:364:12: loop variable val now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/format_major_version.go:547:7: loop variable l now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/format_major_version.go:549:8: loop variable f now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/version_set.go:691:13: loop variable levelMetadata now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/version_set.go:772:10: loop variable lm now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction_picker.go:986:10: loop variable input now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction_picker.go:1108:10: loop variable cl now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction_picker.go:1983:9: loop variable cl now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction_picker.go:2048:10: loop variable in now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:680:9: loop variable cl now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:780:9: loop variable in now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:1270:11: loop variable info now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:1633:9: loop variable cl now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:1696:9: loop variable cl now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:2553:10: loop variable in now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:2577:9: loop variable h now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:2813:10: loop variable cl now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:3125:10: loop variable v now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:3159:10: loop variable v now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:3482:9: loop variable cl now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/compaction.go:3752:9: loop variable f now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/open.go:1129:13: loop variable files now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/level_checker.go:535:9: loop variable t now per-iteration, stack-allocated
../go/pkg/mod/github.com/cockroachdb/[email protected]/table_stats.go:217:9: loop variable levelMetadata now per-iteration, stack-allocated
# github.com/hashicorp/go-sockaddr
../go/pkg/mod/github.com/hashicorp/[email protected]/ifaddrs.go:249:9: loop variable intf now per-iteration, stack-allocated
# gopkg.in/square/go-jose.v2
../go/pkg/mod/gopkg.in/square/[email protected]/jwe.go:187:9: loop variable recipient now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/square/[email protected]/crypter.go:511:9: loop variable recipient now per-iteration, heap-allocated
../go/pkg/mod/gopkg.in/square/[email protected]/signing.go:415:9: loop variable signature now per-iteration, stack-allocated
# gopkg.in/yaml.v3
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:108:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1561:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1618:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1676:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1733:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1903:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1943:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1988:6: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:108:6: loop variable i now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1523)
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:108:6: loop variable i now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1533)
../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:108:6: loop variable i now per-iteration, stack-allocated (loop inlined into ../go/pkg/mod/gopkg.in/[email protected]/emitterc.go:1547)
# github.com/iotexproject/iotex-core/v2/api/logfilter
./action/receipt.go:203:9: loop variable action.topic now per-iteration, heap-allocated (loop inlined into api/logfilter/logfilter.go:47)
# github.com/ethereum/go-ethereum/core/rawdb
../go/pkg/mod/github.com/iotexproject/[email protected]/core/rawdb/database.go:606:9: loop variable ancient now per-iteration, stack-allocated
# github.com/iotexproject/iotex-core/v2/blockchain/blockdao
blockchain/blockdao/blockdao.go:146:6: loop variable i now per-iteration, stack-allocated
# github.com/dop251/goja
../go/pkg/mod/github.com/dop251/[email protected]/runtime.go:361:9: loop variable frame now per-iteration, stack-allocated
../go/pkg/mod/github.com/dop251/[email protected]/builtin_error.go:21:9: loop variable frame now per-iteration, stack-allocated
../go/pkg/mod/github.com/dop251/[email protected]/builtin_string.go:633:10: loop variable item now per-iteration, stack-allocated
# github.com/iotexproject/iotex-core/v2/blockindex
blockindex/bloomfilterindexer.go:333:11: loop variable topic now per-iteration, stack-allocated
blockindex/bloomfilterindexer.go:349:11: loop variable topic now per-iteration, stack-allocated
# github.com/shirou/gopsutil/v3/disk
../go/pkg/mod/github.com/shirou/gopsutil/[email protected]/disk/disk_darwin.go:26:9: loop variable stat now per-iteration, stack-allocated
# github.com/mattn/go-sqlite3
../go/pkg/mod/github.com/mattn/[email protected]/callback.go:134:6: loop variable handle now per-iteration, stack-allocated
../go/pkg/mod/github.com/mattn/[email protected]/sqlite3.go:2044:7: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/github.com/mattn/[email protected]/sqlite3.go:2054:7: loop variable i now per-iteration, stack-allocated
../go/pkg/mod/github.com/mattn/[email protected]/sqlite3.go:2115:6: loop variable i now per-iteration, stack-allocated
# github.com/iotexproject/iotex-election/committee
../go/pkg/mod/github.com/iotexproject/[email protected]/committee/recordtableoperator.go:199:7: loop variable h now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/committee/deltarecordtableoperator.go:192:7: loop variable h now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/trie
../go/pkg/mod/github.com/iotexproject/[email protected]/trie/sync.go:429:9: loop variable op now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/core/state/snapshot
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/snapshot/snapshot.go:548:6: loop variable hash now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/snapshot/snapshot.go:577:6: loop variable hash now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/snapshot/snapshot.go:601:6: loop variable accountHash now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/snapshot/snapshot.go:609:7: loop variable storageHash now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/snapshot/conversion.go:189:13: loop variable head now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/snapshot/conversion.go:372:6: loop variable leaf now per-iteration, stack-allocated
# github.com/libp2p/go-libp2p/p2p/host/eventbus
../go/pkg/mod/github.com/libp2p/[email protected]/p2p/host/eventbus/basic.go:245:6: loop variable i now per-iteration, stack-allocated
# github.com/libp2p/go-netroute
../go/pkg/mod/github.com/libp2p/[email protected]/netroute_bsd.go:128:9: loop variable iface now per-iteration, stack-allocated
# github.com/libp2p/go-libp2p/p2p/net/upgrader
../go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/upgrader/upgrader.go:247:9: loop variable m now per-iteration, heap-allocated (loop inlined into ../go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/upgrader/upgrader.go:240)
../go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/upgrader/upgrader.go:247:9: loop variable m now per-iteration, heap-allocated (loop inlined into ../go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/upgrader/upgrader.go:259)
# github.com/ethereum/go-ethereum/core/state
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/statedb.go:828:6: loop variable addr now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/statedb.go:914:6: loop variable addr now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/statedb.go:1111:6: loop variable addr now per-iteration, heap-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/statedb.go:1385:6: loop variable addr now per-iteration, heap-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/state_object.go:257:6: loop variable key now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/state_object.go:301:6: loop variable key now per-iteration, heap-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state/state_object.go:301:11: loop variable value now per-iteration, heap-allocated
# github.com/klauspost/compress/huff0
../go/pkg/mod/github.com/klauspost/[email protected]/huff0/compress.go:537:9: loop variable v now per-iteration, stack-allocated
../go/pkg/mod/github.com/klauspost/[email protected]/huff0/compress.go:552:9: loop variable v now per-iteration, stack-allocated
# github.com/iotexproject/iotex-core/v2/action/protocol/execution/evm
action/protocol/execution/evm/evmstatedbadapter.go:730:9: loop variable addr now per-iteration, stack-allocated
action/protocol/execution/evm/evmstatedbadapter.go:1067:9: loop variable addr now per-iteration, heap-allocated
action/protocol/execution/evm/evmstatedbadapter.go:1090:9: loop variable addr now per-iteration, heap-allocated
action/protocol/execution/evm/evmstatedbadapter.go:1098:6: loop variable addr now per-iteration, stack-allocated
# golang.org/x/net/ipv4
../go/pkg/mod/golang.org/x/[email protected]/ipv4/sys_asmreq.go:80:9: loop variable ifi now per-iteration, heap-allocated
# github.com/koron/go-ssdp/internal/multicast
../go/pkg/mod/github.com/koron/[email protected]/internal/multicast/interface.go:30:9: loop variable ifi now per-iteration, stack-allocated
../go/pkg/mod/github.com/koron/[email protected]/internal/multicast/multicast.go:70:9: loop variable ifi now per-iteration, stack-allocated
../go/pkg/mod/github.com/koron/[email protected]/internal/multicast/multicast.go:116:9: loop variable ifi now per-iteration, heap-allocated
# github.com/iotexproject/iotex-core/v2/action/protocol/poll
action/protocol/poll/lifelong_protocol.go:33:9: loop variable delegate now per-iteration, stack-allocated
# github.com/libp2p/go-libp2p/p2p/host/resource-manager
../go/pkg/mod/github.com/libp2p/[email protected]/p2p/host/resource-manager/limit_defaults.go:428:9: loop variable l now per-iteration, stack-allocated
../go/pkg/mod/github.com/libp2p/[email protected]/p2p/host/resource-manager/limit_defaults.go:500:9: loop variable l now per-iteration, stack-allocated
# github.com/iotexproject/iotex-core/v2/state/factory
state/factory/workingset.go:478:15: loop variable receivedNonces now per-iteration, stack-allocated
state/factory/util.go:69:11: loop variable topic now per-iteration, heap-allocated
# github.com/libp2p/go-nat
../go/pkg/mod/github.com/libp2p/[email protected]/natpmp.go:69:9: loop variable iface now per-iteration, stack-allocated
../go/pkg/mod/github.com/libp2p/[email protected]/upnp.go:30:10: loop variable dev now per-iteration, stack-allocated
../go/pkg/mod/github.com/libp2p/[email protected]/upnp.go:87:10: loop variable dev now per-iteration, stack-allocated
../go/pkg/mod/github.com/libp2p/[email protected]/upnp.go:306:9: loop variable iface now per-iteration, stack-allocated
# github.com/klauspost/compress/zstd
../go/pkg/mod/github.com/klauspost/[email protected]/zstd/fse_decoder.go:277:9: loop variable v now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/core
../go/pkg/mod/github.com/iotexproject/[email protected]/core/state_transition.go:333:10: loop variable hash now per-iteration, stack-allocated
# github.com/ethereum/go-ethereum/internal/ethapi
../go/pkg/mod/github.com/iotexproject/[email protected]/internal/ethapi/api.go:721:10: loop variable key now per-iteration, stack-allocated
../go/pkg/mod/github.com/iotexproject/[email protected]/internal/ethapi/transaction_args.go:345:9: loop variable c now per-iteration, heap-allocated
# github.com/miekg/dns
../go/pkg/mod/github.com/miekg/[email protected]/types.go:1497:9: loop variable p now per-iteration, stack-allocated
../go/pkg/mod/github.com/miekg/[email protected]/msg.go:799:9: loop variable r now per-iteration, stack-allocated
../go/pkg/mod/github.com/miekg/[email protected]/msg.go:921:10: loop variable r now per-iteration, stack-allocated
../go/pkg/mod/github.com/miekg/[email protected]/msg.go:985:9: loop variable r now per-iteration, stack-allocated
../go/pkg/mod/github.com/miekg/[email protected]/ztypes.go:304:9: loop variable x now per-iteration, stack-allocated
../go/pkg/mod/github.com/miekg/[email protected]/ztypes.go:830:9: loop variable e now per-iteration, stack-allocated
../go/pkg/mod/github.com/miekg/[email protected]/msg_truncate.go:66:9: loop variable r now per-iteration, stack-allocated
# github.com/ipfs/go-log/tracer
../go/pkg/mod/github.com/ipfs/[email protected]/tracer/span.go:196:9: loop variable ld now per-iteration, stack-allocated
# github.com/iotexproject/iotex-core/v2/api
api/grpcserver.go:700:9: loop variable log now per-iteration, stack-allocated
api/grpcserver.go:702:10: loop variable s now per-iteration, stack-allocated
api/web3server_marshal.go:409:9: loop variable tpc now per-iteration, stack-allocated
api/web3server_utils.go:556:13: loop variable log now per-iteration, stack-allocated
./action/receipt.go:203:9: loop variable action.topic now per-iteration, heap-allocated (loop inlined into api/grpcserver.go:560)
./action/receipt.go:203:9: loop variable action.topic now per-iteration, heap-allocated (loop inlined into api/loglistener.go:37)
# github.com/libp2p/go-libp2p/p2p/net/swarm
../go/pkg/mod/github.com/libp2p/[email protected]/p2p/net/swarm/swarm_dial.go:435:9: loop variable addr now per-iteration, stack-allocated
# github.com/libp2p/go-libp2p-kad-dht/pb
../go/pkg/mod/github.com/libp2p/[email protected]/pb/dht.pb.go:465:10: loop variable e now per-iteration, stack-allocated
../go/pkg/mod/github.com/libp2p/[email protected]/pb/dht.pb.go:471:10: loop variable e now per-iteration, stack-allocated
# github.com/quic-go/quic-go
../go/pkg/mod/github.com/quic-go/[email protected]/server.go:505:10: loop variable p now per-iteration, stack-allocated
# github.com/ipld/go-ipld-prime/node/bindnode
../go/pkg/mod/github.com/ipld/[email protected]/node/bindnode/repr.go:653:6: loop variable idx now per-iteration, stack-allocated
../go/pkg/mod/github.com/ipld/[email protected]/node/bindnode/repr.go:843:7: loop variable idx now per-iteration, stack-allocated
# github.com/libp2p/go-libp2p-kad-dht/netsize
../go/pkg/mod/github.com/libp2p/[email protected]/netsize/netsize.go:265:6: loop variable i now per-iteration, stack-allocated
# internal/profile
../../sdk/go1.23.3/src/internal/profile/encode.go:251:10: loop variable l now per-iteration, stack-allocated
../../sdk/go1.23.3/src/internal/profile/encode.go:285:9: loop variable i now per-iteration, stack-allocated
# github.com/libp2p/go-libp2p-pubsub
../go/pkg/mod/github.com/libp2p/[email protected]/gossipsub.go:1386:6: loop variable topic now per-iteration, stack-allocated
../go/pkg/mod/github.com/libp2p/[email protected]/gossipsub.go:1386:13: loop variable peers now per-iteration, stack-allocated
../go/pkg/mod/github.com/libp2p/[email protected]/gossipsub.go:1569:13: loop variable peers now per-iteration, stack-allocated
# github.com/libp2p/go-libp2p/p2p/transport/webtransport
../go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/cert_manager.go:183:9: loop variable certHash now per-iteration, stack-allocated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderZhi CoderZhi CoderZhi left review comments

@dustinxie dustinxie Awaiting requested review from dustinxie dustinxie is a code owner

@Liuhaai Liuhaai Awaiting requested review from Liuhaai Liuhaai is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@envestcc @CoderZhi