Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go1.23.3 #4532

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.21.4
go-version: 1.23.3
cache: false

- name: Build Go
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: 1.21.4
go-version: 1.23.3

- name: make iotex-server/ioctl
if: startsWith(matrix.os, 'windows-latest') != true
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.21.4-alpine as build
FROM golang:1.23.3-alpine as build

WORKDIR apps/iotex-core

Expand Down
8 changes: 4 additions & 4 deletions action/receipt.go
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,11 @@ func (log *Log) ConvertToLogPb() *iotextypes.Log {
l.Topics = [][]byte{}
for _, topic := range log.Topics {
if log.NotFixTopicCopyBug {
l.Topics = append(l.Topics, topic[:])
// the topic copy bug is auto fixed after go1.22, b/c after which each iteration of the loop creates new variables.
// refer to [go1.22 Changes to the language](https://tip.golang.org/doc/go1.22#language)
l.Topics = append(l.Topics, log.Topics[len(log.Topics)-1][:])
} else {
data := make([]byte, len(topic))
copy(data, topic[:])
l.Topics = append(l.Topics, data)
l.Topics = append(l.Topics, topic[:])
}
}
l.Data = log.Data
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/iotexproject/iotex-core/v2

go 1.21
go 1.23.3

require (
github.com/agiledragon/gomonkey/v2 v2.11.0
Expand Down
Loading