feat: Add support for target_modules List #439
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
target_modules
LoRAConfig parameter specifies which parts of the model should be adapted using LoRA. It can either be a string or string array. This PR adds support for array type arguments. It also does a validation check that target_modules is either of type string or string array.Example usage of target modules here
https://github.com/huggingface/peft/blob/main/src/peft/tuners/lora/config.py#L51-L58
https://stackoverflow.com/questions/76768226/target-modules-for-applying-peft-lora-on-different-models