feat: Add support for target_modules List

api/v1alpha1/params_validation.go

@@ -108,6 +108,38 @@
 	return &config, nil
 }
 
+func validateLoraConfigViaConfigMap(cm *corev1.ConfigMap) *apis.FieldError {
+	config, err := UnmarshalTrainingConfig(cm)
+	if err != nil {
+		return err
+	}
+	loraConfig := config.TrainingConfig.LoraConfig
+	if loraConfig != nil {
+		loraConfigRaw, loraConfigExists := loraConfig["LoraConfig"]
+		if loraConfigExists {
+			targetModulesValue, found, err := utils.SearchRawExtension(loraConfigRaw, "target_modules")
+			if err != nil {
+				return apis.ErrGeneric(fmt.Sprintf("Failed to parse 'target_modules' in ConfigMap '%s' in namespace '%s': %v", cm.Name, cm.Namespace, err), "target_modules")
+			}
+			if found {
+				switch v := targetModulesValue.(type) {
+				case string:
+					// Valid single string
+				case []interface{}:
+					for _, item := range v {
+						if _, ok := item.(string); !ok {
+							return apis.ErrInvalidValue(fmt.Sprintf("All elements in 'target_modules' must be strings in ConfigMap '%s' in namespace '%s'", cm.Name, cm.Namespace), "target_modules")
+						}
+					}
+				default:
+					return apis.ErrInvalidValue(fmt.Sprintf("'target_modules' must be either a string or an array of strings in ConfigMap '%s' in namespace '%s'", cm.Name, cm.Namespace), "target_modules")
+				}
+			}
+		}
+	}
+	return nil
+}
+
 func validateTrainingArgsViaConfigMap(cm *corev1.ConfigMap) *apis.FieldError {
 	config, err := UnmarshalTrainingConfig(cm)
 	if err != nil {
@@ -273,6 +305,9 @@
 		if err := validateTrainingArgsViaConfigMap(&cm); err != nil {
 			errs = errs.Also(err)
 		}
+		if err := validateLoraConfigViaConfigMap(&cm); err != nil {
+			errs = errs.Also(err)
+		}
 	}
 	return errs
 }

api/v1alpha1/workspace_validation_test.go

@@ -116,7 +116,7 @@ func defaultConfigMapManifest() *v1.ConfigMap {
   LoraConfig:
     r: 16
     lora_alpha: 32
-    target_modules: "query_key_value"
+    target_modules: ["query_key_value"]
     lora_dropout: 0.05
     bias: "none"
 

presets/tuning/text-generation/parser.py

@@ -26,6 +26,10 @@ def flatten_config_to_cli_args(config, prefix=''):
     for key, value in config.items():
         if isinstance(value, dict):
             cli_args.extend(flatten_config_to_cli_args(value, prefix=f'{prefix}{key}_'))
+        elif isinstance(value, list):
+            cli_arg = f'--{prefix}{key}'
+            cli_args.append(cli_arg)
+            cli_args.extend(map(str, value))
         else:
             cli_arg = f'--{prefix}{key}'
             cli_args.append(cli_arg)