Fix: Inconclusive test counts #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francisco2002
force-pushed
the
fix/inconclusive-test-counts
branch
from
72a5692 to
623ad6a
Compare
WilsonNet
force-pushed
the
feat/others-tree-endpoint
branch
from
30f1089 to
7e0ad8f
Compare
Francisco2002
force-pushed
the
fix/inconclusive-test-counts
branch
from
623ad6a to
654c4fb
Compare
WilsonNet
force-pushed
the
feat/others-tree-endpoint
branch
2 times, most recently
from
b385ab9 to
381adb9
Compare
Francisco2002
force-pushed
the
fix/inconclusive-test-counts
branch
from
654c4fb to
3aa1040
Compare
WilsonNet
reviewed
Jan 15, 2025
| issue_id=issue_id, | ||
| incident_test_id=incident_test_id | ||
| ) | ||
| if test_id is not None: |
There was a problem hiding this comment.
use early return or early continue to avoid nested ifs, otherwise it becomes a hadouken
- tree details - tree commits history - hardware details Part of #741
Francisco2002
force-pushed
the
fix/inconclusive-test-counts
branch
from
3717b43 to
344209e
Compare
Francisco2002
force-pushed
the
fix/inconclusive-test-counts
branch
from
344209e to
d131336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of code are ignoring tests with
nullpath, while other parts are ignoring this tests.To make consistent, the follow approach is implemented:
nullpath as nonboot testsClose #741