Fix: Inconclusive test counts

backend/kernelCI_app/helpers/treeDetails.py

@@ -16,6 +16,7 @@
     env_misc_value_or_default,
 )
 from kernelCI_app.cache import getQueryCache, setQueryCache
+from kernelCI_app.utils import is_boot
 from django.db import connection
 
 
@@ -231,9 +232,7 @@ def get_hardware_filter(row_data: dict) -> Any:
 
 def is_test_boots_test(row_data: dict) -> bool:
     test_path = row_data["test_path"]
-    if test_path.startswith("boot"):
-        return True
-    return False
+    return is_boot(test_path)
 
 
 def get_build(row_data: dict) -> dict:

backend/kernelCI_app/utils.py

@@ -72,3 +72,7 @@ def string_to_json(string: str) -> Optional[dict]:
         except json.JSONDecodeError as e:
             log_message(e.msg)
             return None
+
+
+def is_boot(path: str | None) -> bool:
+    return path is not None and (path == "boot" or path.startswith("boot."))

backend/kernelCI_app/views/hardwareDetailsView.py

@@ -16,7 +16,11 @@
 from kernelCI_app.cache import getQueryCache, setQueryCache
 from kernelCI_app.viewCommon import create_details_build_summary
 from kernelCI_app.models import Tests
-from kernelCI_app.utils import create_issue, extract_error_message
+from kernelCI_app.utils import (
+    create_issue,
+    extract_error_message,
+    is_boot
+)
 from django.views.decorators.csrf import csrf_exempt
 from kernelCI_app.helpers.trees import get_tree_heads
 from kernelCI_app.helpers.filters import UNKNOWN_STRING, FilterParams
@@ -100,10 +104,6 @@ def get_history(record: Dict):
     }
 
 
-def is_boot(record: Dict) -> bool:
-    return record["path"] == "boot" or record["path"].startswith("boot.")
-
-
 def get_record_tree(record: Dict, selected_trees: List) -> Optional[Dict]:
     for tree in selected_trees:
         if (
@@ -386,7 +386,7 @@ def sanitize_records(self, records, trees: List, is_all_selected: bool):
                 compatibles.update(record["environment_compatible"])
 
             tree_index = current_tree["index"]
-            is_record_boot = is_boot(record)
+            is_record_boot = is_boot(record['path'])
             # TODO -> Unify with tree_status_key, be careful with the pluralization
             test_filter_key = "boot" if is_record_boot else "test"
 
@@ -411,7 +411,8 @@ def sanitize_records(self, records, trees: List, is_all_selected: bool):
                 continue
 
             should_process_test = (
-                self.test_in_filter(test_filter_key, record)
+                record['id'] is not None
+                and self.test_in_filter(test_filter_key, record)
                 and record["id"] not in processed_tests
             )
 

backend/kernelCI_app/views/treeCommitsHistory.py

@@ -15,7 +15,7 @@
     build_misc_value_or_default,
     env_misc_value_or_default,
 )
-from kernelCI_app.utils import getErrorResponseBody
+from kernelCI_app.utils import getErrorResponseBody, is_boot
 from rest_framework.views import APIView
 from rest_framework.response import Response
 from rest_framework import status
@@ -225,10 +225,6 @@ def _process_tests(self, row: Dict) -> None:
         incident_test_id = row["incidents_test_id"]
         build_valid = row["build_valid"]
 
-        is_boot = test_path is not None and test_path.startswith(
-            "boot"
-        )
-
         commit_hash = row["git_commit_hash"]
 
         if issue_id is None and (
@@ -237,7 +233,10 @@ def _process_tests(self, row: Dict) -> None:
         ):
             issue_id = UNKNOWN_STRING
 
-        if is_boot:
+        if test_id is None:
+            return
+
+        if is_boot(test_path):
             self._process_boots_count(
                 test_id=test_id,
                 test_status=test_status,

dashboard/src/components/TestsTable/DefaultTestsColumns.tsx

@@ -44,6 +44,7 @@ export const defaultColumns: ColumnDef<TPathTests>[] = [
           fail={row.original.fail_tests}
           skip={row.original.skip_tests}
           error={row.original.error_tests}
+          nullStatus={row.original.null_tests}
         />
       );
     },

dashboard/src/components/TestsTable/TestsTable.tsx

@@ -124,7 +124,7 @@ export function TestsTable({
           groups[group].skip_tests++;
           break;
         default:
-          if (!e.status) groups[group].null_tests++;
+          groups[group].null_tests++;
       }
     });
     return Object.values(groups);