-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s gateway extensions: allow customizing translator #9471
Conversation
Visit the preview URL for this PR (updated for commit 001d07d): https://gloo-edge--pr9471-stevenctl-allow-cust-hm20ywqs.web.app (expires Wed, 31 Jul 2024 17:37:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, just want confirmation about the registry creation semantics for portal
8428f9e
to
840cb77
Compare
9a25138
to
3af543c
Compare
e99ccf5
to
46aecbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a PR on the enterprise side to update the implementations of the interface after this PR merges otherwise LGTM
c8b4bbe
to
c41563c
Compare
Description
API changes
The only API is an internal code API to allow GME to take control of the Gateway translation.
Changed
CreatePluginRegistry
toGetPluginRegistry
. AFAICT there is no need to recreate the registry each time but I can rever tthis if needed.Added:
GetTranslator
to allow conditionally switching the translation logic based on the type of gateway.Context
See slack conversation here