Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up: making argument final #3490

Merged

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Nov 28, 2023

Fixes #

Proposed Changes

  • as per title: making argument final

Release Note


Docs

Signed-off-by: Matthias Wessendorf <[email protected]>
Copy link

knative-prow bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@knative-prow knative-prow bot requested review from aliok and Cali0707 November 28, 2023 11:37
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/data-plane labels Nov 28, 2023
@matzew
Copy link
Contributor Author

matzew commented Nov 28, 2023

/assign @Cali0707

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (82960d8) 61.53% compared to head (90a918a) 61.54%.
Report is 1 commits behind head on main.

Files Patch % Lines
...roker/dispatcher/main/ConsumerVerticleBuilder.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3490   +/-   ##
=========================================
  Coverage     61.53%   61.54%           
  Complexity      765      765           
=========================================
  Files           181      181           
  Lines         12414    12414           
  Branches        266      266           
=========================================
+ Hits           7639     7640    +1     
+ Misses         4165     4164    -1     
  Partials        610      610           
Flag Coverage Δ
java-unittests 70.90% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@knative-prow knative-prow bot merged commit c124bac into knative-extensions:main Nov 28, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants