Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up: making argument final #3490

Merged
merged 1 commit into from
Nov 28, 2023
Merged

clean up: making argument final #3490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .../main/java/dev/knative/eventing/kafka/broker/dispatcher/main/ConsumerVerticleBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,10 @@
};
}

private WebClientOptions createWebClientOptionsFromCACerts(String CACerts) {
if (CACerts != null && !CACerts.isEmpty()) {
private WebClientOptions createWebClientOptionsFromCACerts(final String caCerts) {
if (caCerts != null && !caCerts.isEmpty()) {
return new WebClientOptions(consumerVerticleContext.getWebClientOptions())
.setPemTrustOptions(new PemTrustOptions().addCertValue(Buffer.buffer(CACerts)));
.setPemTrustOptions(new PemTrustOptions().addCertValue(Buffer.buffer(caCerts)));

Check warning on line 218 in data-plane/dispatcher/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/main/ConsumerVerticleBuilder.java

View check run for this annotation

Codecov / codecov/patch

data-plane/dispatcher/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/main/ConsumerVerticleBuilder.java#L218 

Added line #L218 was not covered by tests
}
return consumerVerticleContext.getWebClientOptions();
}
Expand Down
Loading