Bump to 3.10.x Quarkus.io and align libraries #3872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
approved
|
Let's see how this goes ... |
knative-prow
bot
added
the
do-not-merge/hold
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3872 +/- ##
=======================================
Coverage 45.44% 45.44%
=======================================
Files 270 270
Lines 19893 19893
=======================================
Hits 9041 9041
Misses 10133 10133
Partials 719 719 ☔ View full report in Codecov by Sentry. |
|
/test reconciler-tests |
|
/retest |
pierDipi
changed the title
knative-prow
bot
added
the
do-not-merge/work-in-progress
|
/retest |
knative-prow-robot
added
the
needs-rebase
knative-prow-robot
removed
the
needs-rebase
knative-prow-robot
added
the
needs-rebase
|
/test unit-tests |
knative-prow-robot
removed
the
needs-rebase
matzew
force-pushed
the
quarkus_3.10
branch
2 times, most recently
from
bd94e45 to
3d381ff
Compare
|
This Pull Request is stale because it has been open for 90 days with |
github-actions
bot
added
lifecycle/stale
knative-prow-robot
added
the
needs-rebase
knative-prow-robot
removed
the
needs-rebase
matzew
commented
Jan 7, 2025
| @@ -57,7 +57,8 @@ public LoomKafkaProducer(Vertx v, Producer<K, V> producer) { | |||
| final var ctxInt = ((ContextInternal) v.getOrCreateContext()).unwrap(); | |||
| if (ctxInt.tracer() != null) { | |||
| this.tracer = | |||
| new ProducerTracer(ctxInt.tracer(), TracingPolicy.PROPAGATE, "" /* TODO add bootrstrap servers */); | |||
| new ProducerTracer(this.vertx.tracer(), TracingPolicy.PROPAGATE, "" /* TODO add bootrstrap servers */); | |||
There was a problem hiding this comment.
@tsegismont Even changing this, still is causing the ReceiverVerticleTracingTest unit test to fail
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
This reverts commit dfc8b4a.
In Vert.x 4.5.1, there was a fix to use the OTel default context storage when the Vert.x context storage provider is not invoked on a Vert.x thread. See eclipse-vertx/vertx-tracing#72 Since LoomKafkaProducer invokes the tracer on a virtual thread (or a worker thread), the sending task must be wrapped with the OTel current context. Otherwise, tracing data will be lost at this point. OTel provides an ExecutorService that does just that, so this commit refactors the producer to use an executor service instead of a queue plus manual polling. Important: note that with this implementation, a virtual thread is created for each record, which is different from sending them one after the other with a single thread.
matzew
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
matzew
changed the title
|
/test reconciler-tests-namespaced-broker |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest
Sent from Gmail Mobile
…On Tue 14. Jan 2025 at 12:41, knative-prow[bot] ***@***.***> wrote:
@matzew <https://github.com/matzew>: The following test *failed*, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
reconciler-tests-namespaced-broker_eventing-kafka-broker_main db70907
<db70907>
link
<https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-extensions_eventing-kafka-broker/3872/reconciler-tests-namespaced-broker_eventing-kafka-broker_main/1879117803387097088>
true /test reconciler-tests-namespaced-broker
Your PR dashboard <https://prow.knative.dev/pr>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes-sigs/prow
<https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
Reply to this email directly, view it on GitHub
<#3872 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTRYJDNNBQKLWQPNTWD2KTZXVAVCNFSM6AAAAABHDRNYOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBZGY4TGOBQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
|
Glad I was able to contribute here 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Release Note
Docs