Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken symlink to deprecated resource configs #4232

Closed

Conversation

dsimansk
Copy link
Contributor

Fixes #

Proposed Changes

  • Remove broken symlink to deprecated resource configs

Affecting release script during resouce generation:

2025/01/26 10:49:07 Building knative.dev/eventing-kafka-broker/control-plane/cmd/webhook-kafka for linux/arm64/v8
Error: error processing import paths in "control-plane/config/eventing-kafka-source/200-controller/100-config-kafka-descheduler.yaml": open control-plane/config/eventing-kafka-source/200-controller/100-config-kafka-descheduler.yaml: no such file or directory
+ EXIT_VALUE=1

Per title, the original files were removed in #4189. This PR will remove dangling symlinks too.

I'll create cherry-pick PR immediately to skip merge dance with bot.

Release Note

Remove broken symlink to deprecated resource configs

/cc @pierDipi @creydr @knative-extensions/knative-release-leads

@knative-prow knative-prow bot requested review from creydr, pierDipi, a team and skonto and removed request for a team January 26, 2025 12:26
Copy link

knative-prow bot commented Jan 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/control-plane labels Jan 26, 2025
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.32%. Comparing base (ae8a755) to head (a855247).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4232   +/-   ##
=======================================
  Coverage   45.32%   45.32%           
=======================================
  Files         290      290           
  Lines       19869    19869           
=======================================
  Hits         9005     9005           
  Misses      10151    10151           
  Partials      713      713           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

knative-prow bot commented Jan 26, 2025

@dsimansk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
channel-reconciler-tests-ssl_eventing-kafka-broker_main a855247 link true /test channel-reconciler-tests-ssl
integration-tests_eventing-kafka-broker_main a855247 link true /test integration-tests
upgrade-tests_eventing-kafka-broker_main a855247 link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dsimansk
Copy link
Contributor Author

Duplicate PR
/close

@knative-prow knative-prow bot closed this Jan 27, 2025
Copy link

knative-prow bot commented Jan 27, 2025

@dsimansk: Closed this PR.

In response to this:

Duplicate PR
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant