chore: fix lint errors #6576
knative-style.yaml
on: pull_request
style
/
changes
7s
style
/
...
/
Auto-format and Check
23s
style
/
...
/
Lint
3m 37s
style
/
...
/
Do Not Submit
13s
style
/
...
/
shell
19s
style
/
...
/
yaml
29s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
25 errors and 6 warnings
style / Golang / Boilerplate Check (go):
cmd/apiserver_receive_adapter/main.go#L2
[Go headers] reported by reviewdog ๐ถ
found mismatched boilerplate lines:
Raw Output:
cmd/apiserver_receive_adapter/main.go:2: found mismatched boilerplate lines:
{[]string}[0]:
-: "Copyright 2024 The Knative Authors"
+: "Copyright 2024 The Knative Authors."
|
style / Golang / Boilerplate Check (go):
cmd/pong/main.go#L8
[Go headers] reported by reviewdog ๐ถ
found mismatched boilerplate lines:
Raw Output:
cmd/pong/main.go:8: found mismatched boilerplate lines:
{[]string}[0]:
-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
+: " https://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Boilerplate Check (go):
config/brokers/mt-channel-broker/deployments/placeholder.go#L8
[Go headers] reported by reviewdog ๐ถ
found mismatched boilerplate lines:
Raw Output:
config/brokers/mt-channel-broker/deployments/placeholder.go:8: found mismatched boilerplate lines:
{[]string}[0]:
-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
+: " https://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Boilerplate Check (go):
config/brokers/mt-channel-broker/placeholder.go#L8
[Go headers] reported by reviewdog ๐ถ
found mismatched boilerplate lines:
Raw Output:
config/brokers/mt-channel-broker/placeholder.go:8: found mismatched boilerplate lines:
{[]string}[0]:
-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
+: " https://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Boilerplate Check (go):
config/brokers/mt-channel-broker/roles/placeholder.go#L8
[Go headers] reported by reviewdog ๐ถ
found mismatched boilerplate lines:
Raw Output:
config/brokers/mt-channel-broker/roles/placeholder.go:8: found mismatched boilerplate lines:
{[]string}[0]:
-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
+: " https://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Boilerplate Check (go):
config/channels/in-memory-channel/configmaps/placeholder.go#L8
[Go headers] reported by reviewdog ๐ถ
found mismatched boilerplate lines:
Raw Output:
config/channels/in-memory-channel/configmaps/placeholder.go:8: found mismatched boilerplate lines:
{[]string}[0]:
-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
+: " http://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Boilerplate Check (go):
config/channels/in-memory-channel/deployments/placeholder.go#L8
[Go headers] reported by reviewdog ๐ถ
found mismatched boilerplate lines:
Raw Output:
config/channels/in-memory-channel/deployments/placeholder.go:8: found mismatched boilerplate lines:
{[]string}[0]:
-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
+: " http://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Boilerplate Check (go):
config/channels/in-memory-channel/placeholder.go#L8
[Go headers] reported by reviewdog ๐ถ
found mismatched boilerplate lines:
Raw Output:
config/channels/in-memory-channel/placeholder.go:8: found mismatched boilerplate lines:
{[]string}[0]:
-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
+: " http://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Boilerplate Check (go):
config/channels/in-memory-channel/resources/placeholder.go#L8
[Go headers] reported by reviewdog ๐ถ
found mismatched boilerplate lines:
Raw Output:
config/channels/in-memory-channel/resources/placeholder.go:8: found mismatched boilerplate lines:
{[]string}[0]:
-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
+: " http://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Boilerplate Check (go)
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
style / Golang / Lint:
config/300-eventtype.yaml#L64
[trailing whitespace] reported by reviewdog ๐ถ
type: array
Raw Output:
config/300-eventtype.yaml:64: type: array
|
style / Golang / Lint:
config/core/resources/eventtype.yaml#L64
[trailing whitespace] reported by reviewdog ๐ถ
type: array
Raw Output:
config/core/resources/eventtype.yaml:64: type: array
|
style / Golang / Lint:
pkg/kncloudevents/http_client.go#L85
createNewClient - result 1 (error) is always nil (unparam)
|
style / Golang / Lint:
pkg/reconciler/broker/controller.go#L128
`NewController$3` - `obj` is unused (unparam)
|
style / Golang / Lint:
pkg/scheduler/statefulset/scheduler.go#L363
func `toJSONable` is unused (unused)
|
style / Golang / Lint:
pkg/reconciler/source/duck/duck.go#L45
const `defaultNamespace` is unused (unused)
|
style / Golang / Lint:
test/rekt/features/channel/helpers.go#L101
func `patchChannelable` is unused (unused)
|
style / Golang / Lint:
cmd/jobsink/main.go#L204
SA1019: h.oidcTokenVerifier.VerifyJWTFromRequest is deprecated: use OIDCTokenVerifier.Verify() instead to bundle AuthN and AuthZ verification (staticcheck)
|
style / Golang / Lint:
cmd/jobsink/main.go#L385
SA1019: h.oidcTokenVerifier.VerifyJWTFromRequest is deprecated: use OIDCTokenVerifier.Verify() instead to bundle AuthN and AuthZ verification (staticcheck)
|
style / Golang / Lint:
pkg/reconciler/sinkbinding/sinkbinding.go#L39
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
|
style / Golang / Lint:
test/lib/logexporter.go#L84
SA1019: prow.IsCI is deprecated: use knative.dev/pkg/test/ci.IsCI (staticcheck)
|
style / Golang / Lint:
test/lib/logexporter.go#L97
SA1019: prow.GetLocalArtifactsDir is deprecated: use knative.dev/pkg/test/ci.GetLocalArtifactsDir (staticcheck)
|
style / Golang / Lint:
docs/mt-channel-based-broker/mt-channel-broker.png#L1294
[EOF Newline] reported by reviewdog ๐ถ
Missing newline
Raw Output:
docs/mt-channel-based-broker/mt-channel-broker.png:1294: Missing newline
|
style / Golang / Lint:
docs/planning/images/featureplanning.png#L32
[EOF Newline] reported by reviewdog ๐ถ
Missing newline
Raw Output:
docs/planning/images/featureplanning.png:32: Missing newline
|
style / Golang / Lint:
docs/planning/images/releaseplanning.png#L75
[EOF Newline] reported by reviewdog ๐ถ
Missing newline
Raw Output:
docs/planning/images/releaseplanning.png:75: Missing newline
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / suggester / shell
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / suggester / yaml
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|