Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor new filters tests to use single feature set #7424

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Nov 1, 2023

Fixes #7396

Proposed Changes

  • Pass in a function which installs a broker in a given feature instead of installing it in the environment
  • Put all of the features into one feature set so that future dependency sync PRs to ekb will add them to the ekb tests automatically

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Nov 1, 2023
@Cali0707
Copy link
Member Author

Cali0707 commented Nov 1, 2023

/cc @pierDipi @Leo6Leo @creydr

@knative-prow knative-prow bot requested review from creydr, Leo6Leo and pierDipi November 1, 2023 17:22
Signed-off-by: Calum Murray <[email protected]>
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8f4624) 76.74% compared to head (3a57587) 76.74%.
Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7424   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files         253      253           
  Lines       13916    13916           
=======================================
  Hits        10680    10680           
  Misses       2702     2702           
  Partials      534      534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any problem in the PR.

@Cali0707
Copy link
Member Author

Cali0707 commented Nov 1, 2023

/test reconciler-tests

Signed-off-by: Calum Murray <[email protected]>
Cali0707 and others added 2 commits November 14, 2023 09:47
@Cali0707 Cali0707 requested a review from pierDipi November 14, 2023 14:56
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
Copy link

knative-prow bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member Author

Cali0707 commented Dec 4, 2023

/retest-required

@knative-prow knative-prow bot merged commit 6f29571 into knative:main Dec 4, 2023
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the new trigger tests so that they are all in a single FeatureSet
3 participants