Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS port variables #640

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Add HTTPS port variables #640

merged 1 commit into from
Mar 23, 2022

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Mar 23, 2022

This patch adds HTTPS port variables.

Part of knative/serving#12501.

/cc @evankanderson @ZhiminXiang @carlisia

This patch adds HTTPS port variables.
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #640 (3258a05) into main (ec52d71) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files          38       38           
  Lines         810      810           
=======================================
  Hits          766      766           
  Misses         31       31           
  Partials       13       13           
Impacted Files Coverage Δ
pkg/apis/networking/ports.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec52d71...3258a05. Read the comment docs.

@nak3
Copy link
Contributor Author

nak3 commented Mar 23, 2022

knative/serving#12770 is the code to demonstrate how to use this variables.

Copy link

@ZhiminXiang ZhiminXiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 55757e9 into knative:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants