Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Hops Encrypted: Activator serving TLS #12770

Merged
merged 29 commits into from
Apr 13, 2022
Merged

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Mar 23, 2022

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/autoscale area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Mar 23, 2022
@knative-prow-robot
Copy link
Contributor

@nak3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-serving-unit-tests 91385e9 link true /test pull-knative-serving-unit-tests
pull-knative-serving-build-tests 91385e9 link true /test pull-knative-serving-build-tests
pull-knative-serving-kourier-stable 91385e9 link true /test pull-knative-serving-kourier-stable
pull-knative-serving-kourier-stable-tls 91385e9 link true /test pull-knative-serving-kourier-stable-tls
pull-knative-serving-istio-latest-no-mesh-tls 91385e9 link true /test pull-knative-serving-istio-latest-no-mesh-tls
pull-knative-serving-istio-latest-no-mesh 91385e9 link true /test pull-knative-serving-istio-latest-no-mesh
pull-knative-serving-upgrade-tests 91385e9 link true /test pull-knative-serving-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2022
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2022
@nak3 nak3 changed the title WIP: All Hops Encrypted: Activator serving TLS All Hops Encrypted: Activator serving TLS Mar 31, 2022
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #12770 (a7254bc) into main (ad15a85) will increase coverage by 0.04%.
The diff coverage is 80.95%.

❗ Current head a7254bc differs from pull request most recent head 248eb28. Consider uploading reports for the commit 248eb28 to get more accurate results

@@            Coverage Diff             @@
##             main   #12770      +/-   ##
==========================================
+ Coverage   87.44%   87.49%   +0.04%     
==========================================
  Files         196      197       +1     
  Lines        9782    14334    +4552     
==========================================
+ Hits         8554    12541    +3987     
- Misses        938     1503     +565     
  Partials      290      290              
Impacted Files Coverage Δ
cmd/activator/main.go 0.00% <0.00%> (ø)
pkg/reconciler/domainmapping/reconciler.go 93.62% <33.33%> (+1.52%) ⬆️
pkg/networking/util.go 88.00% <88.00%> (ø)
pkg/reconciler/autoscaling/hpa/hpa.go 91.66% <88.88%> (+0.49%) ⬆️
pkg/reconciler/autoscaling/config/store.go 100.00% <100.00%> (ø)
pkg/reconciler/autoscaling/kpa/kpa.go 95.18% <100.00%> (+0.06%) ⬆️
pkg/reconciler/route/resources/ingress.go 96.18% <100.00%> (+3.04%) ⬆️
...reconciler/serverlessservice/resources/services.go 100.00% <100.00%> (ø)
pkg/queue/handler.go 90.24% <0.00%> (-3.31%) ⬇️
pkg/autoscaler/statforwarder/leases.go 72.39% <0.00%> (-3.15%) ⬇️
... and 194 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e75bcf0...248eb28. Read the comment docs.

@nak3
Copy link
Contributor Author

nak3 commented Mar 31, 2022

/cc @evankanderson @skonto @rhuss

@skonto
Copy link
Contributor

skonto commented Mar 31, 2022

/retest

cmd/activator/main.go Outdated Show resolved Hide resolved
test/generate-cert.sh Outdated Show resolved Hide resolved
@nak3
Copy link
Contributor Author

nak3 commented Apr 12, 2022

Thank you @evankanderson @skonto I think this is ready now.

@evankanderson
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022
@nak3 nak3 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@knative-prow knative-prow bot merged commit 2de1474 into knative:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All Hops Encrypted: Activator serving TLS
5 participants