Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linter config and address lint warnings/failures #3068

Merged
merged 22 commits into from
Jun 25, 2024

fix unit test

bf64ccd
Select commit
Loading
Failed to load commit list.
Merged

Update linter config and address lint warnings/failures #3068

fix unit test
bf64ccd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 25, 2024 in 1s

78.44% (target 68.00%)

View this Pull Request on Codecov

78.44% (target 68.00%)

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.44%. Comparing base (8535fcc) to head (bf64ccd).
Report is 1 commits behind head on main.

Files Patch % Lines
apis/condition_set.go 0.00% 1 Missing ⚠️
apis/testing/roundtrip/roundtrip.go 0.00% 1 Missing ⚠️
metrics/resource_view.go 0.00% 1 Missing ⚠️
reconciler/configstore.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3068      +/-   ##
==========================================
+ Coverage   78.42%   78.44%   +0.02%     
==========================================
  Files         191      191              
  Lines        8939     8936       -3     
==========================================
  Hits         7010     7010              
+ Misses       1666     1664       -2     
+ Partials      263      262       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.