Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

Add Servers section configuration for knative-ingress-gateway #258

Closed
wants to merge 1 commit into from
Closed

Add Servers section configuration for knative-ingress-gateway #258

wants to merge 1 commit into from

Conversation

eqqe
Copy link

@eqqe eqqe commented Jan 20, 2020

Fixes #160

@googlebot googlebot added the cla: yes Author(s) signed a CLA. label Jan 20, 2020
@knative-prow-robot
Copy link
Contributor

Hi @eqqe. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@houshengbo
Copy link

/ok-to-test

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eqqe
To complete the pull request process, please assign k4leung4
You can assign the PR to them by writing /assign @k4leung4 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/knativeserving/common/gateway.go 100.0% 91.3% -8.7

Copy link
Contributor

@jcrossley3 jcrossley3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In light of on-going work to abstract the various ingress impls, I'm hesitant to embed an Istio API into our CRD. See https://docs.google.com/document/d/1Kwy13f36aeBv8slYy2OkpSRE6OKkkk2nAldiEq49Ybg/edit

/hold

@k4leung4
Copy link
Contributor

+1 to what @jcrossley3 said
While Istio is the common ingress option, embedding Istio API seems counter to what has been happening in the knative/serving where they are looking to pull out istio specific logic

@knative-prow-robot
Copy link
Contributor

@eqqe: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aliok
Copy link
Member

aliok commented Mar 2, 2020

#302 might be the solution for this problem. I also don't think having Istio things in the CRD(s) is a good idea.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The serving-operator incorrectly re-initialize knative-ingress-gateway configuration
9 participants