-
Notifications
You must be signed in to change notification settings - Fork 45
Add Servers section configuration for knative-ingress-gateway #258
Conversation
Hi @eqqe. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eqqe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In light of on-going work to abstract the various ingress impls, I'm hesitant to embed an Istio API into our CRD. See https://docs.google.com/document/d/1Kwy13f36aeBv8slYy2OkpSRE6OKkkk2nAldiEq49Ybg/edit
/hold
+1 to what @jcrossley3 said |
@eqqe: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#302 might be the solution for this problem. I also don't think having Istio things in the CRD(s) is a good idea. |
Fixes #160