Implement e2e test for internal encryption

[KauzClay]

Fixes #

Proposed Changes

• net-contour now has support for internal-encryption. This change will add some sort of e2e test to make sure things are working properly.
• Removes placeholder added in Add setup script for internal-encryption e2e test #13559
• Reverted original approach of running a specific test: Revert "add new job to run internal encryption tests for Contour (#36… test-infra#3694

Release Note
N/A

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Base: 86.16% // Head: 86.24% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (e5c1202) compared to base (f4792e4).
Patch has no changes to coverable lines.

❗ Current head e5c1202 differs from pull request most recent head 541d155. Consider uploading reports for the commit 541d155 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13536      +/-   ##
==========================================
+ Coverage   86.16%   86.24%   +0.07%     
==========================================
  Files         197      197              
  Lines       14790    14783       -7     
==========================================
+ Hits        12744    12749       +5     
+ Misses       1743     1733      -10     
+ Partials      303      301       -2     

Impacted Files	Coverage Δ
pkg/autoscaler/statserver/server.go	75.91% <0.00%> (-1.46%)	⬇️
pkg/queue/sharedmain/main.go	0.61% <0.00%> (+<0.01%)	⬆️
pkg/reconciler/route/resources/ingress.go	95.00% <0.00%> (+0.19%)	⬆️
pkg/autoscaler/scaling/multiscaler.go	88.59% <0.00%> (+1.34%)	⬆️
pkg/reconciler/route/route.go	81.23% <0.00%> (+1.52%)	⬆️
pkg/reconciler/revision/resolve.go	85.00% <0.00%> (+7.50%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[KauzClay]

/test contour-internal-encryption

[mgencur]

Hi! Looking at the "kourier" variant, the internal TLS is configured in e2e-common.sh here based on the ENABLE_TLS flag. This flag is enabled via github action here. This way all the E2E tests in Serving run with internal TLS enabled for kourier. The github action run can be seen above as e2e / test (v1.24.7, kourier-tls, e2e) (pull_request)
I'm wondering if you could use the same approach for net-kontour. Basically, you don't need to add any new test, just add one variant of github action with internal tls enabled. The test coverage will be higher as all tests will run with tls and it will be aligned with the already existing solution for kourier.

[KauzClay]

hi @mgencur thanks for sharing that! I think that makes sense, I was worried my approach wasn't going to be able to test very much anyway.

I will look into it

[KauzClay]

okay, I've tried out @mgencur 's suggestions. They're all failing currently, but I'm thinking that is because it is using Contour 1.23.x. The net-contour internal-encryption compatibility relies on some changes coming in Contour 1.24. That should be out soon.

In the mean-time, I will try bringing in the release candidate to my fork of net-contour and test this PR out with that.

[KauzClay]

As an update, looks like the only failing tests using the new Contour 1.24 are the DomainMapping api tests. I think I see what is going on there, so I started a new issue: #13659

EDIT: moved the issue to net-contour repo: knative-extensions/net-contour#862

[KauzClay]

Contour 1.24.0 is available, hopefully that can get pulled into net-contour soon.

UPDATE: I'm drafting a PR to test it out here

[KauzClay]

This PR (knative-extensions/net-contour#860) should make the failing contour-tls api tests pass here

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KauzClay
Once this PR has been reviewed and has the lgtm label, please assign zroubalik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[KauzClay]

I just rebased with main, so serving should have my changes for knative-extensions/net-contour#860 in 51ed9ad. Hopefully the tests all pass now 🤞

[KauzClay]

looks like those changes didn't work, trying again with knative-extensions/net-contour#878

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

[KauzClay]

closing in favor of #14092