Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "add new job to run internal encryption tests for Contour (#36… #3694

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Revert "add new job to run internal encryption tests for Contour (#36… #3694

merged 1 commit into from
Jan 30, 2023

Conversation

KauzClay
Copy link
Contributor

@KauzClay KauzClay commented Jan 30, 2023 •
edited
Loading

This reverts commit 71d8478.

What this PR does, why we need it:

Based on feedback here: knative/serving#13536

There is a different approach that will get much better test coverage than this test job.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2023
@knative-prow knative-prow bot requested review from krsna-m and psschwei January 30, 2023 16:00
@krsna-m
Copy link
Contributor

krsna-m commented Jan 30, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023
@KauzClay KauzClay mentioned this pull request Jan 30, 2023
Closed
psschwei
psschwei reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

psschwei
psschwei reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow
Copy link

knative-prow bot commented Jan 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KauzClay, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023
@knative-prow knative-prow bot merged commit 1a7ca66 into knative:main Jan 30, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 30, 2023

@KauzClay: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key serving-main.gen.yaml using file prow/jobs/generated/knative/serving-main.gen.yaml

In response to this:

This reverts commit 71d8478.

What this PR does, why we need it:

Based on feedback here: knative/serving#13536

There is a different approach that will get much better test coverage than this test job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees

@psschwei psschwei

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KauzClay @krsna-m @psschwei